I have tested this item ✅ successfully on bcc3ce8

2 questions why do you use * .5 instead of / 2 ? And isn't awesome 6.0 a b/c break. Iirc fontawesome has some really strange naming breaks for some icons in major versions I might be wrong

2 questions why do you use * .5 instead of / 2 ?

Because slash is used as both a separator and as division

About FA6: their changelog doesn't mention any major breaks: https://fontawesome.com/docs/changelog/

EDIT: FA6 changed the names of some icons, the list is here but they provide a scss file that bridges the names (use both names, v5 + v6). I will update this PR to include this later today

About choices.js (which also has a major version update), their changelog also doesn't state any major B/C breaks: https://github.com/Choices-js/Choices/releases/tag/v10.0.0

About the slash on the scss @brianteeman already posted their post for the why, The TL:DR; is the / is a CSS modifier but in SCSS was also used for math devision. The math division now should be possible only using math.div($x, $y);...

@HLeithner the shims file is imported so this should be 100% B/C

Please fix conflicts.

I have tested this item ✅ successfully on 27eaa7b

I have tested this item ✅ successfully on 27eaa7b

RTC

Check that nothing is broken visually

Before 1

After 1

Before 2

After 2

Before 3 - weight?

After 3 - weight?

There are LOTS of other icon changes. In general they probably dont matter but where we have maybe used an icon for something other than its original purpose the changes are not good.

I thought they said there was a b/c shim in fontawesom6

I thought they said there was a b/c shim in fontawesom6

There is and we are using it but it covers the name changes. For the visual changes someone needs to diff both icon sets and do any adjustments, if there is a new name that fits better the existing mapping. I did that for icomoon and quite frankly I'm not up to the task this time as it takes forever (5000+ icons). I'm not saying that it shouldn't happen but I don't have the time for this atm, so if this is a deal breaker someone else needs to take over here

so if this is a deal breaker someone else needs to take over here

I am just the messenger ;)

I like the update, but will not include a new FA version in a patch release, so will rebase to 4.2 and let @roland-d and @fancyFranci decide how the changed icons should be handled.

@dgrammatiko I sent you a PR to fix the conflict, after that I can merge this PR. Thank you.

after that I can merge this PR

About merging this PR: @brianteeman already spotted some visual changes due to the upgrade to v6 of Font Awesome. This might need some research (it's just comparing the font icon names using the 2 different sites v5 and v6, making some notes and then maybe figure out if some other mapping is making more sense for the current use case, it's a bit of work...)

It would be nice to roll an article that 4.2 will use FA v6 and ask devs to adjust (early) their code eg from:

font-family: "Font Awesome 5 Free";

to

font-family: "Font Awesome 6 Free","Font Awesome 5 Free";

Also this is the only part that needs to be documented

Please merge. I noticed it too, however, this can be done in separate PR which I can do.

Thank you @Quy I am just waiting for Drone and AppVeyor to finish.

@roland-d do you want me to do some back port of this to 4.1 (without the FA v6) or someone already on it?

do/should we really be updating fontawesome? \they are breaking changes AND fs5 is designated LTS

do/should we really be updating fontawesome? \they are breaking changes AND fs5 is designated LTS

FA v5 still has the deprecated div notifications and there is not update but also it's not the end of the world we could override some values locally and fix it in this repo if there's no fix upstream. Anyways, not my decision, I could redo this with the v5...

the deprecated div notifications
which are not seen by the user

which are not seen by the user

True, but it's annoying for devs (not really a reason) and might be a problem for new contributors (not really, if there was a nice welcoming DX)
Also there's no documentation that states that the node audit/deprecations/etc are irrelevant for the distributed product

FWIW this PR's intention was to just fix the math div deprecations, the FA upgrade shouldn't be part of this. Probably I was too fast to jump on the newest-greatest train without thinking too much. I'll try to do a PR in the 4.1 with only the needed changes and close this. If there's a decision to go with v6, diffing the changes here and making a new pr should be a 5min job...

agreed

and 6,1 comes out next week

OK closing here the PR for 4.1 is here: #37243

If anyone still wants to upgrade to FA v6 the code is here

Hi guys,
sorry,I did not understand. At the end FA6 will not be included into the J4.1, right ?
But, Will it be added in J4.2 ?

Hello,

This will not be in Joomla 4.2 nor do I know when it will come.

Hi
There are lots of new icons Font Awesome v6 :-)
Do you know when this can be integrated? 4.2.3 ?
or what is the method to integrate it now ? if there is no date

Font Awesome icon packs are not backward compatible, so upgrading them would break other websites. if we upgrade it, it's
likely to be in Joomla 5.0.

Font Awesome icon packs are not backward compatible, so upgrading them would break other websites. if we upgrade it, it's likely to be in Joomla 5.0.

Hi
Sniff, thank you for the clarification.