Feeling Lucky
?
NPM Resource Changed
?
[#36879] - [4.1] Fix the SCSS file paths
- Fixed in Code Base
- 22 Feb 2022
- Medium
- Build: 4.1-dev
- # 36879
- Diff
- dgrammatiko:patch-14
User tests: Successful: Unsuccessful:
Pull Request for Issue #36872.
Summary of Changes
- The SCSS files delivered in the templates have wrong paths due to the source moved in the
buildfolder, so we have to patch them. - Fixes the Atum imports pointing at the node_modules resources
Testing Instructions
Before applying this PR try:
npm run build:css -- media/templates/site/cassiopeia/scssnpm run build:css -- media/templates/administrator/atum/scss
Both commands will fail because the paths are wrong.
Apply this PR and rerun the commands:
npm run build:css -- media/templates/site/cassiopeia/scssnpm run build:css -- media/templates/administrator/atum/scss
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
| Category | JavaScript Repository | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
|
||
HarshJaiswani
- comment
- 9 Feb 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36879.
Aman21591
- comment
- 9 Feb 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36879.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 9 Feb 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36879.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-22 14:44:41 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 22 Feb 2022
Thx
Please fix conflicts.