? ? Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
28 Jan 2022

Summary of Changes

Finder auto-suggestions for search fields are broken due to encoded URL for suggestion requests.

Testing Instructions

Load finder page, enable suggestions, try to search for any existing word, see requests with encoded & and invalid data.

Actual result BEFORE applying this Pull Request

Finder suggestions are broken.

Expected result AFTER applying this Pull Request

Finder suggestions are fine.

Documentation Changes Required

No.

d87915b 28 Jan 2022 avatar Denitz fix
avatar Denitz Denitz - open - 28 Jan 2022
avatar Denitz Denitz - change - 28 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2022
Category Front End com_finder Modules
avatar Denitz Denitz - change - 28 Jan 2022
Title
fix
[4.0] Finder auto-suggestions broken
avatar Denitz Denitz - edited - 28 Jan 2022
avatar richard67
richard67 - comment - 28 Jan 2022

@bembelimen Should this be rebased to 4.1-dev?

avatar bembelimen
bembelimen - comment - 28 Jan 2022

There will be most likely no 4.0 merges anymore (if not a security issue comes up), so yes please.

avatar richard67
richard67 - comment - 28 Jan 2022

@Denitz Let us know if you need help with rebasing the PR to the 4.1-dev branch.

7852c7f 28 Jan 2022 avatar Denitz fix
avatar Denitz Denitz - change - 28 Jan 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2022
Category Front End com_finder Modules Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_banners
avatar Denitz Denitz - change - 28 Jan 2022
Title
[4.0] Finder auto-suggestions broken
[4.1] Finder auto-suggestions broken
avatar Denitz Denitz - edited - 28 Jan 2022
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2022
Category Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_banners Front End com_finder Modules
avatar Denitz
Denitz - comment - 28 Jan 2022

@richard67 I rebased this PR.

avatar Quy Quy - test_item - 30 Jan 2022 - Tested successfully
avatar Quy
Quy - comment - 30 Jan 2022

I have tested this item successfully on 3be67ab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36877.

avatar Shubhamverma2796 Shubhamverma2796 - test_item - 1 Feb 2022 - Tested successfully
avatar Shubhamverma2796
Shubhamverma2796 - comment - 1 Feb 2022

I have tested this item successfully on 3be67ab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36877.

avatar richard67 richard67 - change - 1 Feb 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 1 Feb 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36877.

avatar Denitz Denitz - change - 21 Feb 2022
Labels Added: ? ?
Removed: ?
avatar bembelimen bembelimen - change - 22 Feb 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-22 00:47:39
Closed_By bembelimen
avatar bembelimen bembelimen - close - 22 Feb 2022
avatar bembelimen bembelimen - merge - 22 Feb 2022
avatar bembelimen
bembelimen - comment - 22 Feb 2022

Thx

Add a Comment

Login with GitHub to post a comment