? ? Pending

User tests: Successful: Unsuccessful:

avatar pjdevries
pjdevries
27 Jan 2022

Summary of Changes

Adds the possibility of passing ordering parameters to com_content web service requests in \Joomla\Component\Content\Api\Controller\ArticlesController::displayList()

Testing Instructions

Make a request to https://<your website>/api/index.php/v1/content/articles.
Add either or both of the following parameters to the request uri:

  • list[ordering]=field_name (where field_name is the name of a field in the SELECT list of the query)
  • list[direction]=direction (where direction is ASC or DESC).

Actual result BEFORE applying this Pull Request

Articles returned by the request will always be in DESCending order by article id.

Expected result AFTER applying this Pull Request

Depending on the ordering parameters passed, articles returned by the request will be in the desired ASCending or DESCending order by the field specified.

Documentation Changes Required

Obviously, as this is a new feature.

avatar pjdevries pjdevries - open - 27 Jan 2022
avatar pjdevries pjdevries - change - 27 Jan 2022
Status New Pending
avatar pjdevries pjdevries - change - 28 Jan 2022
Labels Added: ?
avatar pjdevries
pjdevries - comment - 28 Jan 2022

@alikon I'm quite sure your dev setup is such, that you can quickly test this PR :) Would you be so kind?

avatar pjdevries pjdevries - change - 28 Jan 2022
The description was changed
avatar pjdevries pjdevries - edited - 28 Jan 2022
avatar pjdevries pjdevries - change - 28 Jan 2022
The description was changed
avatar pjdevries pjdevries - edited - 28 Jan 2022
avatar pjdevries pjdevries - change - 28 Jan 2022
The description was changed
avatar pjdevries pjdevries - edited - 28 Jan 2022
avatar pjdevries pjdevries - change - 28 Jan 2022
The description was changed
avatar pjdevries pjdevries - edited - 28 Jan 2022
avatar richard67
richard67 - comment - 29 Jan 2022

@bembelimen Should this be rebased to 4.2-dev?

avatar pjdevries
pjdevries - comment - 29 Jan 2022

Please don't. It's such a simple PR, with no impact on anything else, whatsoever.

avatar pjdevries
pjdevries - comment - 29 Jan 2022

I mean, include it in 4.1 please.

avatar pjdevries
pjdevries - comment - 29 Jan 2022

Apologies for my remarks @richard67. @roland-d just pointed out that 4.1 is RC and does not allow new features. Stupid me.

avatar roland-d roland-d - test_item - 29 Jan 2022 - Tested successfully
avatar roland-d
roland-d - comment - 29 Jan 2022

I have tested this item successfully on 569af00

Before the PR the articles came in order of the ID descending. After applying the PR I was able to retrieve articles sorted on the field specified and ordered by the ordering I supplied.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36876.

avatar alikon alikon - test_item - 29 Jan 2022 - Tested successfully
avatar alikon alikon - test_item - 29 Jan 2022 - Tested successfully
avatar alikon alikon - alter_testresult - 30 Jan 2022 - alikon: Tested successfully
avatar alikon alikon - change - 30 Jan 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 30 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36876.

avatar richard67 richard67 - change - 1 Feb 2022
Title
[4.1] - Adds ordering parameters to web service requests.
[4.2] - Adds ordering parameters to web service requests.
avatar richard67 richard67 - edited - 1 Feb 2022
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2022
Category Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_content com_fields com_finder com_languages com_media com_menus com_workflow Language & Strings JavaScript NPM Change Front End
avatar richard67 richard67 - change - 1 Feb 2022
Labels Added: ? ? Language Change NPM Resource Changed ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2022
Category Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_content com_fields com_finder com_languages com_media com_menus com_workflow Language & Strings JavaScript NPM Change Front End
avatar roland-d roland-d - change - 1 Feb 2022
Labels Removed: ? Language Change NPM Resource Changed
avatar fancyFranci fancyFranci - change - 3 Feb 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-02-03 21:06:41
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 3 Feb 2022
avatar fancyFranci fancyFranci - merge - 3 Feb 2022
avatar fancyFranci
fancyFranci - comment - 3 Feb 2022

Thank you!

avatar alexandreelise
alexandreelise - comment - 26 Apr 2022

nice one.

Add a Comment

Login with GitHub to post a comment