[#36873] - Fix redirect updating new_url value
- Closed
- 8 Feb 2022
- Medium
- Build: 4.0-dev
- # 36873
- Diff
- tonypartridge:patch-9
User tests: Successful: Unsuccessful:
Pull Request for Issue #36862 .
Summary of Changes
Remove the direct changes to the redirect object and updating of new_url
Testing Instructions
Without this PR add a redirect and publish it into com_redirects, for example:
Source:
/my-custom-error
Destination
/my-real-live-page
access
/my-custom-error?query_junk_here
Actual result BEFORE applying this Pull Request
you are redirected to:
/my-real-live-page?query_junk_here
Try it again and you will see you are redirected to:
/my-real-live-page?query_junk_here?query_junk_here
Because before this PR the DB is updated.
Expected result AFTER applying this Pull Request
You are redirected to: /my-custom-error?query_junk_here
But your redirect in the database is not changed.
Documentation Changes Required
Back-port to J3 too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
It works as expected in new redirections created after applying the patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36873.
Closing as it will be upmerged from v3.10. Thank you!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-08 18:21:52 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
?
Removed: ? |
||
Could you do a PR there so this can be tested there and merged up? @tonypartridge