[#36872] - [4.1] Core templates SCSS does not compile in release
- Closed
- 28 Jan 2022
- Medium
- Build: 4.1-dev
- # 36872
Try to compile the SCSS of the frontend template for example in media/templates/site/cassiopeia/scss/template.scss That is what we are shipping to our users with 4.1 and it does not compile, since it is a copy from the /build folder to the /media folder. However in the /build folder it is another level deeper than in the /media folder and thus for example the above file tries to include files by traveling one level to high in the filesystem.
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
@dgrammatiko Could you have a look on this issue? Thanks in advance.
The scss folder in the media/... is a deliverable and not the source thus they should NOT used (in conjunction with Joomla's own tools) for compiling the css files, for those you need to use the folder build/.... But anyways the PHP compiler should be abandoned as it's not a real replacement of the actual tools for compiling SCSS to CSS...
However we aren't talking about the PHP compiler, but about the SCSS we are going to ship with 4.1 and that SCSS right now is broken. You can not create an SCSS file which includes that template.scss and run npm to compile it. So please stay on topic.
If those files aren't meant to be compiled, then delete them now and don't deliver them with our release package.
You can, the source files are in the build folder...
If those files aren't meant to be compiled, then delete them now and don't deliver them with our release package.
Yes probably should be removed
You can, the source files are in the build folder...
That folder is not distributed
If those files aren't meant to be compiled, then delete them now and don't deliver them with our release package.
Yes probably should be removed
Irrespective of the phpcss thing having the scss for the templates is useful - assuming that the paths are fixed and they can be used.
@Hackwar raises a valid issue here
Irrespective of the phpcss thing having the scss for the templates is useful
Let me disagree here. Bootstrap 5.2 will have most of their components (I think their missing only the forms, but have;t checked lately) using CSS Variables. Meaning you will never-ever need to recompile Bootstrap... The whole SCSS precompiling is not needed anymore...
Here's what Bootstrap is doing regarding CSS Variables:
What I'm trying to say is JUST KILL SCSS It was a mistake
What I'm trying to say is JUST KILL SCSS It was a mistake
Maybe so but for at least the next 6 months we will be shipping it - so it should be usable
so it should be usable
Ok will try to do a pr this weekend
This can be closed
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-28 10:33:36 |
| Closed_By | ⇒ | richard67 |
How are you trying to compile it?