? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Jan 2022

This is part of the schedule runner js and looks like a bug to me
@ditsuke

avatar brianteeman brianteeman - open - 24 Jan 2022
avatar brianteeman brianteeman - change - 24 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2022
Category JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 24 Jan 2022

The bug seems to cause that in any case 300 seconds are used. As most testing instructions in past were done with 5 minute example, nobody has ever noticed, I guess.

avatar richard67
richard67 - comment - 24 Jan 2022

I have tested this item successfully on 5d516aa

Code review. Obviously a typo, but to be sure I've really checked if there is any PHP or XML or SQL file or any JS beside those fixed by this PR which is using "inverval", and there isn't.

The bug by this typo might have been missed in past because it does not cause any crashing errors, it just makes the scheduler use a wrong value.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36832.

avatar richard67 richard67 - test_item - 24 Jan 2022 - Tested successfully
avatar Quy
Quy - comment - 24 Jan 2022

I have tested this item successfully on 5d516aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36832.

avatar Quy Quy - test_item - 24 Jan 2022 - Tested successfully
avatar Quy Quy - change - 24 Jan 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 24 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36832.

avatar bembelimen bembelimen - change - 25 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-25 00:58:48
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 25 Jan 2022
avatar bembelimen bembelimen - merge - 25 Jan 2022
avatar bembelimen
bembelimen - comment - 25 Jan 2022

Thx

avatar ditsuke
ditsuke - comment - 25 Jan 2022

Thanks!

avatar brianteeman
brianteeman - comment - 25 Jan 2022

thanks

Add a Comment

Login with GitHub to post a comment