? Composer Dependency Changed ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
21 Jan 2022

Followup of #36776 which increases the PHPUnit version to 9 and sets the min PHP version to 7.3.

avatar laoneo laoneo - open - 21 Jan 2022
avatar laoneo laoneo - change - 21 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2022
Category Unit Tests External Library Composer Change Libraries
avatar brianteeman
brianteeman - comment - 21 Jan 2022

Did you mean to include libraries/src/Table/Nested.php

avatar zero-24
zero-24 - comment - 21 Jan 2022

I'm not sure whether it would be wise to upgrade the minimum php version within an minor version. If anything a decision should be made before basing work on it and it should be updated on all places within the CMS ;)

Also the drone file has to be signed before it get executed and can be used. cc @HLeithner as drone maintainer :)

avatar laoneo
laoneo - comment - 21 Jan 2022

This is mainly for testing porposes to see what it means to make the test environment green again.
The nested changes are from the other pr which fixes the system tests.

avatar laoneo laoneo - change - 22 Jan 2022
Labels Added: ? Composer Dependency Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jan 2022
Category Unit Tests External Library Composer Change Libraries Unit Tests External Library Composer Change
avatar 810
810 - comment - 26 Jan 2022

Maybe set the min to php 7.4

7.3 is not supported, also we can update more plugins with 7.4 like codestyling.

avatar laoneo laoneo - change - 4 Feb 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-02-04 07:37:07
Closed_By laoneo
avatar laoneo laoneo - close - 4 Feb 2022

Add a Comment

Login with GitHub to post a comment