? ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar beat
beat
21 Jan 2022

Pull Request for Issue # none, directly fixed here.

Summary of Changes

Fixes Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258

Testing Instructions

Obvious source-code review should be enough.

Otherwise go into admin with PHP 8.1 and debug on, with deprecation warnings turned on.

Actual result BEFORE applying this Pull Request

Displays warning Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258

Expected result AFTER applying this Pull Request

warning disappears.

Documentation Changes Required

None.

avatar beat beat - open - 21 Jan 2022
avatar beat beat - change - 21 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2022
Category Libraries
avatar richard67
richard67 - comment - 22 Jan 2022

I have tested this item successfully on 1a1f786

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36777.

avatar richard67 richard67 - test_item - 22 Jan 2022 - Tested successfully
avatar Fedik
Fedik - comment - 22 Jan 2022

I have tested this item successfully on 1a1f786


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36777.

avatar Fedik Fedik - test_item - 22 Jan 2022 - Tested successfully
avatar Fedik Fedik - change - 22 Jan 2022
Status Pending Ready to Commit
avatar Fedik
Fedik - comment - 22 Jan 2022

R2C


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36777.

avatar beat beat - change - 23 Jan 2022
Labels Added: ? ? ? ?
avatar beat
beat - comment - 23 Jan 2022

Test: I tested the proposed change and it fixes the issue same as my orignal fix proposal.

avatar zero-24
zero-24 - comment - 23 Jan 2022

Merging thanks

avatar zero-24 zero-24 - change - 23 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-23 18:28:49
Closed_By zero-24
avatar zero-24 zero-24 - close - 23 Jan 2022
avatar zero-24 zero-24 - merge - 23 Jan 2022

Add a Comment

Login with GitHub to post a comment