[#36746] - [4.0] Implement FormFactoryAwareInterface in ListModel
- Fixed in Code Base
- 21 Jan 2022
- Medium
- Build: 4.0-dev
- # 36746
- Diff
- heelc29:heelc29-patch-listmodel
User tests: Successful: Unsuccessful:
Summary of Changes
Implement FormFactoryAwareInterface in ListModel to inject FormFactory
Testing Instructions
Open any list view (e.g. list of articles, contacts, extensions) and verify that the search form is displayed as before
Actual result BEFORE applying this Pull Request
UnexpectedValueException: FormFactory not set in Joomla\CMS\MVC\Model\ListModel
And fallback to Factory::getContainer()->get(FormFactoryInterface::class) to get the FormFactory
Expected result AFTER applying this Pull Request
FormFactory is now set in MVCFactory by setFormFactoryOnObject since Model now implements FormFactoryAwareInterface
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
enable debug
in administrator go to Content ->Articles
after apply the pr no more Exception
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36746.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36746.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36746.
As it's a bug fix, it make sense to rebase to 4.1...
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-21 12:53:40 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
|
||
Thx
I guess the question is why? You don't explain how you got this error message, its certainly working without the PR in the core Joomla right?