? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
16 Jan 2022

Pull Request for Issue # .

Summary of Changes

Code refactor

Testing Instructions

This PR needs git pull and npm install!!!

Please apply first #36687 then this PR resolving the conflicts if any

Try to drag and drop an image to tinyMCE's content area

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Documentation Changes Required

No, it's just code refactoring

Based on @laoneo 's PR #36687 that correct's the inserted URL to the actual URL instead of the thumb

avatar dgrammatiko dgrammatiko - open - 16 Jan 2022
avatar dgrammatiko dgrammatiko - change - 16 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2022
Category Administration com_media JavaScript Repository NPM Change Front End Plugins
avatar dgrammatiko dgrammatiko - change - 16 Jan 2022
Labels Added: ? NPM Resource Changed
576ec9e 16 Jan 2022 avatar dgrammatiko CS
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2022
Category Administration com_media JavaScript Repository NPM Change Front End Plugins Administration com_media JavaScript Repository NPM Change
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2022
Category Administration com_media JavaScript Repository NPM Change JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 16 Jan 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 16 Jan 2022
avatar Quy
Quy - comment - 16 Jan 2022

Fixes #36093?

avatar dgrammatiko
dgrammatiko - comment - 16 Jan 2022

Fixes #36093?

I have no clue what's the problem there. They try to drag and drop some HTML elements and this code will not do anything if there's no file in the dragged object. So probably not but then again what is the expectation and is that expectation something that tinyMCE supports or the project wants to support?

avatar dgrammatiko dgrammatiko - change - 16 Jan 2022
The description was changed
avatar dgrammatiko dgrammatiko - edited - 16 Jan 2022
avatar dgrammatiko
dgrammatiko - comment - 17 Jan 2022

This is against the wrong repo

avatar dgrammatiko dgrammatiko - change - 17 Jan 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-01-17 12:51:14
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 17 Jan 2022

Add a Comment

Login with GitHub to post a comment