User tests: Successful: Unsuccessful:
Pull Request for Issue #36453 .
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings JavaScript Repository NPM Change External Library Composer Change |
Labels |
Added:
Language Change
Composer Dependency Changed
NPM Resource Changed
?
|
Category | Administration Language & Strings JavaScript Repository NPM Change External Library Composer Change | ⇒ | Administration Language & Strings JavaScript Repository NPM Change External Library Composer Change Front End Plugins |
@niharikamahajan02 The branch for this PR meanwhile has conflicts due to recent changes in the 4.1-dev branch. You can try to solve the conflicts, but maybe it's easier to make a new PR. In both cases you should update your 4.1-dev branch to the same branch of the upstream repository so it is up to date. Let us know if you need help or advise.
Ok, I will make a new PR then. Thanks
And please look for any occurrences of old strings. I have found a few more.
e.g.
media/com_scheduler/js/admin-view-run-test-task.js
media/com_scheduler/js/admin-view-run-test-task-es5.js
And please look for any occurrences of old strings. I have found a few more.
e.g.
media/com_scheduler/js/admin-view-run-test-task.js media/com_scheduler/js/admin-view-run-test-task-es5.js
Ok sir.
And please look for any occurrences of old strings. I have found a few more.
e.g.
media/com_scheduler/js/admin-view-run-test-task.js media/com_scheduler/js/admin-view-run-test-task-es5.js
I tried changing all the constants in -
media/com_scheduler/js/admin-view-run-test-task.js
media/com_scheduler/js/admin-view-run-test-task-es5.js
and also in other files , but one problem is that even after changing constants in minified js also (in my code editor) that change is not getting reflected in
media/com_scheduler/js/admin-view-run-test-task.min.js like
Do not touch anything in the /media folder
The changes must be made in /build/media-source
Then you run the npm task to rebuild the /media folder (npm run build:js
)
Okay, thanks!
Yes , the problem is now fixed I'll just submit a new PR now.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-18 03:39:23 |
Closed_By | ⇒ | niharikamahajan02 |