[#36667] - [4.0] Remove the local dependency in the media select field
- Fixed in Code Base
- 31 Jan 2022
- Medium
- Build: 4.0-dev
- # 36667
- Diff
- Digital-Peak:j4/media/field-no-local-dep
User tests: Successful: Unsuccessful:
Summary of Changes
The media select field has a hard dependency to the local adapter to insert media data. Instead of it should just check if the media file is a local one or not. This allows adapters which are working with local files as well to insert relative urls.
Testing Instructions
- Download and install the free version DPMedia from here
- Create a Pixabay adapter in the back end as described here
- In the article form select an image from the local adapter
- In the article form select an image from the Pixabay adapter
Actual result BEFORE applying this Pull Request
- Local has a relative url
- Pixabay has the url to pixabay
Expected result AFTER applying this Pull Request
- Local has a relative url
- Pixabay has the url to pixabay
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
It should be the same.
I have tested this item
Also tested with https://restrictedfs.dgrammatiko.dev (alternative local adater)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36667.
I tested it with a local adapter I'm shipping soon with DPMedia and it worked, and now @dgrammatiko tested it with his one. Guess more we can't provide atm.
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36667.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36667.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
Reset as there were some changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36667.
There were no changes, only merge conflicts. So ready to commit.
| Labels |
Removed:
?
|
||
Quy
- | Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-31 15:15:07 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
Removed: ? |
||
Thx
@laoneo Is it right that actual and expected result are the same? Or is that some kind of typo?