[#36656] - [4.1 ScheduledTasks] test task to run task and ACL PERMISSION also updated
- Closed
- 15 Jan 2022
- Medium
- Build: 4.1-dev
- # 36656
- Diff
- niharikamahajan02:change2
User tests: Successful: Unsuccessful:
Pull Request for Issue #36453 (Part 2) .
Summary of Changes
The ACL Permission also renaming and column header test task renamed to run task.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Perhaps a clean renaming of all strings of TEST_RUN and TESTRUN occurrences to RUN_TASK will do the trick.
e.g. COM_SCHEDULER_PERMISSION_RUN_TASK COM_SCHEDULER_RUN_TASK_STATUS_TERMINATED
That also reads much more clearly.
What do you think @brianteeman ?
For replacing all strings of TEST_RUN to RUN_TASK , it's needed to replace respective constants also in modal-content class.
But I am unable to find where this content is written , so will you please inform .
@tecpromotion sir plz inform.
The easiest way is to search for ALL files in the repository or your branch.
I use the full text search in my development environment (PhpStorm).
For example, if you search for COM_SCHEDULER_PERMISSION_TESTRUN across all files, you will find 3 places.
This must then all be adapted and tested.
Of course, the same applies to all other constants and their values.
Does this help you @niharikamahajan02 to create the further changes for this PR?
Okay! thank you @tecpromotion sir.
Yes, I will be able to make further changes for this PR now.
Okay! thank you @tecpromotion sir. Yes, I will be able to make further changes for this PR now.
Perfect. Please close PR #36664
I am looking forward to testing this PR. It makes sense.
| Labels |
Added:
Language Change
?
|
||
| Category | Administration Language & Strings | ⇒ | Administration Language & Strings JavaScript Repository NPM Change |
Even though after changing constants , the heading is not changing as shown below. Is there any specific problem here .
Well among other things you have committed stashed changes from your github repo
Yes because the changes I applied were not getting commited unless I didn't stashed them
Well thats wrong. Your branch was probably not upto datae
Yup okk ,will be making another commit
| Labels |
Added:
NPM Resource Changed
|
||
plz ignore this commit
I think I will have to make a new PR as there is something getting wrong again and again.
Quy
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-15 20:05:09 |
| Closed_By | ⇒ | Quy |
Perhaps a clean renaming of all strings of TEST_RUN and TESTRUN occurrences to RUN_TASK will do the trick.
e.g.
COM_SCHEDULER_PERMISSION_RUN_TASK
COM_SCHEDULER_RUN_TASK_STATUS_TERMINATED
That also reads much more clearly.
What do you think @brianteeman ?