Feeling Lucky
?
?
?
[#36625] - PHP8.1 Deprecation string in trim in banners
- Fixed in Code Base
- 18 Jan 2022
- Medium
- Build: 3.10-dev
- # 36625
- Diff
- PhilETaylor:patch-335
User tests: Successful: Unsuccessful:
Pull Request for Issue #36623 .
Summary of Changes
ensure sensible default before passing to trim()
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
Deprecation notice
Expected result AFTER applying this Pull Request
No deprecation notice.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
alikon
- comment
- 10 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36625.
alikon
- comment
- 10 Jan 2022
should be merged on j4 too
laoneo
- comment
- 10 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36625.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 10 Jan 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36625.
alikon
- comment
- 10 Jan 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36625.
richard67
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-18 16:26:23 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
?
|
||
wilsonge
- comment
- 18 Jan 2022
Thanks!
I have tested this item✅ successfully on ab87c11
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36625.