? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Jan 2022

Some flags have a white background and so they do not display correctly. This is particularly true for the japanese flag but its true for other flags as well.

Before

image

After

image

This is a css change so will require npm run build:css
lets not start another debat here about not using flags or not usings gifs

avatar brianteeman brianteeman - open - 8 Jan 2022
avatar brianteeman brianteeman - change - 8 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jan 2022
Category Repository NPM Change
avatar brianteeman brianteeman - change - 8 Jan 2022
Labels Added: NPM Resource Changed ?
avatar sandewt
sandewt - comment - 10 Jan 2022

I have tested this item successfully on c9bde9c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36609.

avatar sandewt sandewt - test_item - 10 Jan 2022 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Jan 2022

I have tested this item successfully on c9bde9c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36609.

avatar jwaisner jwaisner - test_item - 11 Jan 2022 - Tested successfully
avatar jwaisner jwaisner - change - 11 Jan 2022
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 11 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36609.

avatar bembelimen
bembelimen - comment - 16 Jan 2022

I see the problem here, that any gif everywhere in the backend gets the border.

avatar brianteeman
brianteeman - comment - 16 Jan 2022

Yes I understand that. It was the lowest cost means of correcting the issue

avatar brianteeman
brianteeman - comment - 16 Jan 2022

see #36706 for an alternative solution

avatar bembelimen
bembelimen - comment - 17 Jan 2022

We should go with #36706

avatar bembelimen bembelimen - close - 17 Jan 2022
avatar bembelimen bembelimen - change - 17 Jan 2022
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2022-01-17 09:26:30
Closed_By bembelimen
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Jan 2022

ok

Add a Comment

Login with GitHub to post a comment