? ? Pending

User tests: Successful: Unsuccessful:

avatar pjdevries
pjdevries
5 Jan 2022

Pull Request for Issue #36569.

Summary of Changes

Changes the location where the manifest script.php file is looked for during uninstall, to the library root directory as opposed to the manifests directory

Testing Instructions

For testing purposes use the attached package, which does nothing really useful, other than proving uninstall of library packages is erroneous. It creates a text file named JPATH_LIBRARIES/lib_foo_script.txt, containing a line for each preflight() and postflight() method being executed in script.php, showing the performed installer action (install, uninstall, uograde).

  • Install the attached library package in a clean Joomla! 4.0.x site,
  • Upgrade the library by installing the same package a second time.
  • Uninstall the library.
  • Inspect the created text file.

Beware! If after the first test run, before applying the patch and running the second run, the text file is still there, results for the second run will be appended to the existing file!

Actual result BEFORE applying this Pull Request

File JPATH_LIBRARIES/lib_foo_script.txt contains the following:

preflight: install
postflight: install
preflight: update
postflight: update

As can be seen, preflight() and postflight() methods are neither triggered as part of the update process nor during uninstall.

Expected result AFTER applying this Pull Request

File JPATH_LIBRARIES/lib_foo_script.txt contains the following:

preflight: install
postflight: install
preflight: uninstall
postflight: uninstall
preflight: update
postflight: update
preflight: uninstall
postflight: uninstall

As can be seen, preflight() and postflight() methods are triggered both as part of the update process and during uninstall.

Documentation Changes Required

None

lib_foo.zip

avatar pjdevries pjdevries - open - 5 Jan 2022
avatar pjdevries pjdevries - change - 5 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jan 2022
Category Libraries
avatar pjdevries pjdevries - change - 6 Jan 2022
The description was changed
avatar pjdevries pjdevries - edited - 6 Jan 2022
avatar roland-d
roland-d - comment - 6 Jan 2022

I have tested this item successfully on 941d8e9

I tested this patch successfully. Before the patch the uninstall routine was not triggered. After applying the patch the uninstall routine is triggered.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36570.

avatar roland-d
roland-d - comment - 6 Jan 2022

I have tested this item successfully on 941d8e9

I tested this patch successfully. Before the patch the uninstall routine was not triggered. After applying the patch the uninstall routine is triggered.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36570.

avatar roland-d roland-d - test_item - 6 Jan 2022 - Tested successfully
avatar pjdevries
pjdevries - comment - 6 Jan 2022

Thanx @roland-d . Maybe @alikon or @laoneo can give it a shot too?

avatar alikon
alikon - comment - 7 Jan 2022

I have tested this item successfully on 941d8e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36570.

avatar alikon alikon - test_item - 7 Jan 2022 - Tested successfully
avatar alikon alikon - change - 7 Jan 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 7 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36570.

avatar pjdevries
pjdevries - comment - 7 Jan 2022

Thanx @alikon.

avatar bembelimen bembelimen - close - 21 Jan 2022
avatar bembelimen bembelimen - merge - 21 Jan 2022
avatar bembelimen bembelimen - change - 21 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-21 13:00:47
Closed_By bembelimen
Labels Added: ? ?
avatar bembelimen
bembelimen - comment - 21 Jan 2022

Thx

avatar pjdevries
pjdevries - comment - 21 Jan 2022

And you @bembelimen :)

Add a Comment

Login with GitHub to post a comment