[#36556] - [4.2][bugfix] Media manager icons respect the permissions
- Closed
- 2 Feb 2022
- Medium
- Build: 4.1-dev
- # 36556
- Diff
- dgrammatiko:4.1-dev-mm-cando
User tests: Successful: Unsuccessful:
Pull Request for Issue #36549.
Summary of Changes
- Pass the persmissions from PHP to JS
- Pass the properties to the icons
Testing Instructions
Check the issus
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No, bug
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
The problem is the focus management of the drop-down list (the ellipsis button is a dropdown under the skin) because it's kinda hardcoded to at least some of the options. Suddenly the scope of this PR got way bigger...
Oops. I have a habit of doing that lately.
Oh no, you didn't do anything wrong. Others should be blamed here and I think my name would be also on the list. Anyways this requires quite some refactoring of the buttons and probably I will end up rewriting the whole list view as it's completely inaccessible. That said it's not a 5 mins job...
The whole focus management is completely foobar, that said the code here should do what it was meant to do (hopefully).
| Title |
|
||||||
Folders should not have the pencil icon.
richard67
- | Title |
|
||||||
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-02 20:22:39 |
| Closed_By | ⇒ | dgrammatiko |
Works on images, there's a minor bug on folders where when you hover the triple-dot icon appears, but when you click it, it disappears again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36556.