? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Jan 2022

This PR corrects a bug with the border radius of the search box in rtl (as shown below) and completely removes all the RTL specific css and uses logical properties instead.

The markup uses badge-color but bs5 only has bg-color so the badges were invisible. Also the hover on the card was white on white and that was invisible before

Also removes a few bits of css that are just not needed at all

RTL before

image

RTL after

image

Badges & Hover Before

image

Badges & Hover After

image

avatar brianteeman brianteeman - open - 3 Jan 2022
avatar brianteeman brianteeman - change - 3 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2022
Category Repository NPM Change
c8bf92e 5 Jan 2022 avatar brianteeman bg
avatar brianteeman brianteeman - change - 5 Jan 2022
Labels Added: ? NPM Resource Changed
avatar brianteeman brianteeman - change - 5 Jan 2022
The description was changed
avatar brianteeman brianteeman - edited - 5 Jan 2022
avatar brianteeman brianteeman - change - 5 Jan 2022
Title
[4.0] Install from Web css
[4.0] Install from Web css and invisible badges
avatar brianteeman brianteeman - edited - 5 Jan 2022
avatar Quy
Quy - comment - 5 Jan 2022

I have tested this item successfully on c8bf92e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36547.

avatar Quy Quy - test_item - 5 Jan 2022 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 7 Jan 2022

I have tested this item successfully on c8bf92e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36547.

avatar PhilETaylor PhilETaylor - test_item - 7 Jan 2022 - Tested successfully
avatar Quy Quy - change - 7 Jan 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 7 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36547.

8da8fe3 10 Jan 2022 avatar brianteeman cs
avatar brianteeman brianteeman - change - 10 Jan 2022
Labels Added: ?
avatar brianteeman brianteeman - change - 20 Jan 2022
Title
[4.0] Install from Web css and invisible badges
[4.1] Install from Web css and invisible badges
avatar brianteeman brianteeman - edited - 20 Jan 2022
avatar brianteeman brianteeman - change - 20 Jan 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 20 Jan 2022

rebased to 4.1

avatar bembelimen bembelimen - change - 21 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-21 14:48:19
Closed_By bembelimen
Labels Removed: ?
avatar bembelimen bembelimen - close - 21 Jan 2022
avatar bembelimen bembelimen - merge - 21 Jan 2022
avatar bembelimen
bembelimen - comment - 21 Jan 2022

Thx

avatar brianteeman
brianteeman - comment - 21 Jan 2022

thanks

avatar simbus82
simbus82 - comment - 21 Jan 2022

Thanks @brianteeman, this solve part of point 2 of this issue ;-)
joomla/install-from-web-server#63

Add a Comment

Login with GitHub to post a comment