No Code Attached Yet
avatar PhilETaylor
PhilETaylor
1 Jan 2022

@HLeithner Something has been merged that has broken the build.

All PR builds are now failing.

see: phpmin-api-mysql

Screenshot 2022-01-01 at 11 30 43

avatar PhilETaylor PhilETaylor - open - 1 Jan 2022
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Jan 2022
avatar PhilETaylor PhilETaylor - change - 1 Jan 2022
The description was changed
avatar PhilETaylor PhilETaylor - edited - 1 Jan 2022
avatar PhilETaylor PhilETaylor - change - 1 Jan 2022
The description was changed
avatar PhilETaylor PhilETaylor - edited - 1 Jan 2022
avatar HLeithner
HLeithner - comment - 1 Jan 2022

I restarted https://ci.joomla.org/joomla/joomla-cms/49935/1/1 (last I have seen working for 4.0) checking if it's the image or something merged

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

Looks like this broke it? 6dc01f5

avatar HLeithner
HLeithner - comment - 1 Jan 2022

that's an upmerge from 4.0 to 4.1, 4.1 worked before this upmerge, so it looks more like somthing got merged into 4.0 which is broken

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

Cool - I'll leave it with you :)

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

The law of averages probably says I screwed up then...
Screenshot 2022-01-01 at 11 41 25

avatar HLeithner
HLeithner - comment - 1 Jan 2022
avatar HLeithner
HLeithner - comment - 1 Jan 2022

I like it when PRs are merged blindly...

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022
avatar HLeithner
HLeithner - comment - 1 Jan 2022

good that I thought 4.0 is broken...

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

Screenshot 2022-01-01 at 11 50 17

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

Helper\Api there was changed

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

Confused.

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

maybe this fixes it? #36521

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

yeah that fixes the issue - but now the unit tests fail

 [PHPUnit\Framework\Exception] Undefined index: cmsPath at tests/Codeception/_support/Helper/Api.php:76  
avatar HLeithner
HLeithner - comment - 1 Jan 2022

#36510 benjamin fixed it to on another position but get the same error

avatar dgrammatiko
dgrammatiko - comment - 1 Jan 2022

Didn't someone updated codeception to the next major version? Maybe there's a B/C break there...

avatar bembelimen
bembelimen - comment - 1 Jan 2022

Thanks for the report, we're working on it (thanks @HLeithner for the help). I messed something up at the upmerge.

avatar PhilETaylor
PhilETaylor - comment - 1 Jan 2022

Thanks!

avatar bembelimen bembelimen - change - 1 Jan 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-01-01 20:21:14
Closed_By bembelimen
avatar bembelimen bembelimen - close - 1 Jan 2022

Add a Comment

Login with GitHub to post a comment