? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Jan 2022

Adds the code to handle long descriptions in the same way as with modules - satisfies a @todo

Removes "Are these of use here?" as they're not

Removes "task-params" from the ignore fieldsets. It should not be part of the ignore fieldsets here and only worked because it was actually a typo and should have been "task_params"

avatar brianteeman brianteeman - open - 1 Jan 2022
avatar brianteeman brianteeman - change - 1 Jan 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jan 2022
Category Administration
avatar brianteeman brianteeman - change - 1 Jan 2022
Labels Added: ?
62f3423 1 Jan 2022 avatar brianteeman var
avatar Quy
Quy - comment - 3 Jan 2022

Clicking Show full description ... results in browser's console:

Uncaught TypeError: document.querySelector(...) is null

avatar brianteeman
brianteeman - comment - 3 Jan 2022

@Quy its the same code as for the modules when they have long descriptions. Does it work there?

avatar Quy
Quy - comment - 3 Jan 2022

No. It is also happening in v4.0 so please ignore my report in this PR.

dfdd45d 14 Jan 2022 avatar brianteeman cs
avatar brianteeman
brianteeman - comment - 14 Jan 2022

All requested changes have been made

avatar Quy
Quy - comment - 14 Jan 2022

I have tested this item successfully on 9f4622f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36519.

avatar Quy Quy - test_item - 14 Jan 2022 - Tested successfully
avatar ditsuke
ditsuke - comment - 15 Jan 2022

I have tested this item successfully on 9f4622f

Works as advertised and nothing breaks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36519.

avatar ditsuke ditsuke - test_item - 15 Jan 2022 - Tested successfully
avatar richard67 richard67 - change - 15 Jan 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 15 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36519.

avatar richard67 richard67 - change - 15 Jan 2022
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 15 Jan 2022 - Quy: Tested successfully
avatar richard67 richard67 - alter_testresult - 15 Jan 2022 - ditsuke: Tested successfully
avatar bembelimen bembelimen - change - 20 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-20 02:41:09
Closed_By bembelimen
avatar bembelimen bembelimen - close - 20 Jan 2022
avatar bembelimen bembelimen - merge - 20 Jan 2022
avatar bembelimen
bembelimen - comment - 20 Jan 2022

Thx

avatar brianteeman
brianteeman - comment - 20 Jan 2022

Thanks

Add a Comment

Login with GitHub to post a comment