Feeling Lucky
?
[#36502] - [4] remove Factory::getDbo() deprecated
- Closed
- 31 Dec 2021
- Medium
- Build: 4.0-dev
- # 36502
- Diff
- alikon:prepsql
User tests: Successful: Unsuccessful:
Summary of Changes
get DatabaseDriver from container
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
@deprecated 5.0 — Load the database service from the dependency injection container
Expected result AFTER applying this Pull Request
no more Factory::getDbo(); @deprecated 5.0
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules com_workflow Front End com_content com_users Libraries Modules |
| Labels |
Added:
?
|
||
HLeithner
- comment
- 31 Dec 2021
it would be nice to add the variable type, so the static code analyser has a chance to help auto completing.
alikon
- comment
- 31 Dec 2021
outside pr scope
PhilETaylor
- comment
- 31 Dec 2021
outside pr scope
I disagree. The code you are replacing has a defined return type in the docblock which is used by static analysis, whereas after this PR it's not defined.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-31 17:06:54 |
| Closed_By | ⇒ | alikon |
alikon
- comment
- 31 Dec 2021
ok better status quo then
PhilETaylor
- comment
- 31 Dec 2021
Wow attitude much - just add the 12 lines of copy and paste doc code and move on
I’m pretty sure there are now three open PRs all the same to do this