No Code Attached Yet
avatar xillibit
xillibit
31 Dec 2021

Steps to reproduce the issue

You need to have one or more articles as featured on the home page

Update with last changes from 4.0-dev branch github, go to the frontend you will see the issue :

image

This change is causing the issue : c604191#diff-f16f36bed93f14aa31addbb48b984a3e77da598e5ebd014e7a5157409b6d3087

Expected result

No error

Actual result

PlgContentEmailcloak::_cloak(): Argument #1 ($text) cannot be passed by reference

System information (as much as possible)

Joomla! 4.0.6-dev
Php 8.0.14 and 8.1.1
MySQL 5.7.36

Additional comments

avatar xillibit xillibit - open - 31 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 31 Dec 2021
avatar xillibit xillibit - change - 31 Dec 2021
The description was changed
avatar xillibit xillibit - edited - 31 Dec 2021
avatar xillibit xillibit - change - 31 Dec 2021
The description was changed
avatar xillibit xillibit - edited - 31 Dec 2021
avatar richard67 richard67 - change - 31 Dec 2021
Labels Added: ?
avatar richard67 richard67 - labeled - 31 Dec 2021
avatar richard67
richard67 - comment - 31 Dec 2021

Similar to what is described in the (unrelated) PR #36503 , I think that the error is only thrown on PHP 8, so I set the corresponding label.

avatar xillibit
xillibit - comment - 31 Dec 2021

On Php 7.4.27 and 7.3.33 :

image

avatar richard67
richard67 - comment - 31 Dec 2021

Hmm, ok.

avatar richard67 richard67 - change - 31 Dec 2021
Labels Removed: ?
avatar richard67 richard67 - unlabeled - 31 Dec 2021
avatar xillibit xillibit - change - 31 Dec 2021
The description was changed
avatar xillibit xillibit - edited - 31 Dec 2021
avatar PhilETaylor
PhilETaylor - comment - 31 Dec 2021

I dont see how this was caused by my change - we have always passed $row->text or $row to the _cloak method

avatar xillibit xillibit - change - 31 Dec 2021
The description was changed
avatar xillibit xillibit - edited - 31 Dec 2021
avatar xillibit xillibit - change - 31 Dec 2021
The description was changed
avatar xillibit xillibit - edited - 31 Dec 2021
avatar xillibit
xillibit - comment - 31 Dec 2021

If i remove the articles featured on the home page the error disappear

avatar alikon
alikon - comment - 31 Dec 2021

i confirm @xillibit findings latest changes come from #36442

avatar PhilETaylor
PhilETaylor - comment - 31 Dec 2021

Im looking into it already - but fail to see the root cause as the code is technically the same.

avatar PhilETaylor
PhilETaylor - comment - 31 Dec 2021

ah I see... PR incoming

avatar PhilETaylor
PhilETaylor - comment - 31 Dec 2021

fixed by #36505

avatar richard67 richard67 - change - 31 Dec 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-12-31 16:49:17
Closed_By richard67
avatar richard67 richard67 - close - 31 Dec 2021
avatar richard67
richard67 - comment - 31 Dec 2021

Closing as having a pull request. Please test #36505 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment