[#36493] - [4.0] Minify diff.js
- Fixed in Code Base
- 30 Dec 2021
- Medium
- Build: 4.0-dev
- # 36493
- Diff
- dgrammatiko:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Add vendor/diff/js to the array of scripts that need minification
Testing Instructions
Without PR applied and after "composer install" and npm ci, check if there is a file media/vendor/diff/js/diff.min.js.
Result: No.
Apply the PR and run npm ci again and checked again for that file.
Result: The file is there.
Additional, optional test (requires Linux):
Fetch the branch of this PR into a local branch and run the build script for that current branch.
git fetch upstream pull/36493/head:test-pr-36493
git checkout test-pr-36493
php ./build/build.php --remote=HEAD --exclude-gzip --exclude-bzip2
Check the if the build/tmp/packages/Joomla_4.0.6-dev-Development-Full_Package.zip package contains files media/vendor/diff/js/diff.min.js and media/vendor/diff/js/diff.min.js.gz.
Result: It contains these files, while without the PR it doesn't.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
@dgrammatiko Maybe you can add the first part in the comment of my test result to your testing instructions. The 2nd, optional test is not needed, I think.
@richard67 done and thanks.
@wilsonge please merge this before the next release, thanks
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-30 12:36:46 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on f70fac6
Tested as follows:
Result: No.
Result: The file is there.
Additional, optional test (requires Linux):
Result: It contains these files, while without the PR it doesn't.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36493.