Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36440] - [6.3] Use an injected logger in the Task driver

Feature PR-6.0-dev PR-6.1-dev PR-6.2-dev

User tests: Successful: Unsuccessful:

avatar ditsuke
ditsuke
27 Dec 2021

Summary of Changes

A logger is injected into Task at creation, and into routines through ExecutedTaskEvent at runtime.

Testing Instructions

Tasks should be logged as expected to the scheduler log file "administrator/logs/joomla_scheduler.php".
Logs for individual tasks, if enabled, should be saved to the file as specified in the configuration.

Actual result BEFORE applying this Pull Request

No DI, ugly setup code in TaskPluginTrait etc.

Expected result AFTER applying this Pull Request

DI, less static calls (still depends on the global Log instance to setup sub-loggers! :/), more succinct.

Documentation Changes Required

-

avatar ditsuke ditsuke - open - 27 Dec 2021
avatar richard67 richard67 - change - 31 Dec 2021
The description was changed
Build 4.0-dev ⇒ 4.1-dev
avatar richard67 richard67 - edited - 31 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2021
Category ⇒ Administration
avatar richard67 richard67 - change - 31 Dec 2021
The description was changed
avatar richard67 richard67 - edited - 31 Dec 2021
avatar bembelimen bembelimen - change - 31 Dec 2021
Labels Added: ?
avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar laoneo
laoneo - comment - 21 Oct 2022

@ditsuke can you implement the the suggestions and fix the conflicts?

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[4.1] Use an injected logger in the Task driver
[5.2] Use an injected logger in the Task driver
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
…
[5.2] Use an injected logger in the Task driver
[5.3] Use an injected logger in the Task driver
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar Hackwar
Hackwar - comment - 26 Nov 2024

@ditsuke Are you still working on this?

avatar HLeithner
HLeithner - comment - 4 Mar 2025

This pull request has been automatically rebased to 6.0-dev.

avatar HLeithner HLeithner - change - 4 Mar 2025
Title
…
[5.3] Use an injected logger in the Task driver
[6.0] Use an injected logger in the Task driver
avatar HLeithner HLeithner - edited - 4 Mar 2025
avatar HLeithner
HLeithner - comment - 31 Aug 2025

This pull request has been automatically rebased to 6.1-dev.

avatar HLeithner HLeithner - change - 31 Aug 2025
Title
…
[6.0] Use an injected logger in the Task driver
[6.1] Use an injected logger in the Task driver
avatar HLeithner HLeithner - edited - 31 Aug 2025
avatar github-actions[bot]
github-actions[bot] - comment - 28 Feb 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar HLeithner
HLeithner - comment - 17 Mar 2026

This pull request has been automatically rebased to 6.2-dev.

avatar Hackwar Hackwar - change - 17 Mar 2026
Labels Added: Feature Conflicting Files PR-6.0-dev PR-6.1-dev
Removed: ?
avatar Hackwar Hackwar - change - 17 Mar 2026
Labels Added: PR-6.2-dev
Removed: Conflicting Files
avatar tecpromotion tecpromotion - change - 15 Apr 2026
Title
…
[6.1] Use an injected logger in the Task driver
[6.2] Use an injected logger in the Task driver
avatar tecpromotion tecpromotion - edited - 15 Apr 2026
avatar HLeithner HLeithner - change - 11 Nov 2026
Title
…
[6.2] Use an injected logger in the Task driver
[6.3] Use an injected logger in the Task driver
avatar HLeithner HLeithner - edited - 11 Nov 2026

Add a Comment

Login with GitHub to post a comment