[#36439] - [6.0] Remove ExecRuleHelper
- Pending
- Medium
- Build: 4.1-dev
- # 36439
- Diff
- ditsuke:replace-exec-rule-helper
User tests: Successful: Unsuccessful:
Summary of Changes
Replace the ExecRuleHelper class with Task::computeNextExecution().
Testing Instructions
- Creating new tasks and modifying existing tasks works as expected.
- Triggered tasks computer next execution date as expected from configuration.
Actual result BEFORE applying this Pull Request
ExecRuleHelper exists, for little reason.
Expected result AFTER applying this Pull Request
ExecRuleHelper is safely replaced by Task::computeNextExecution()
Documentation Changes Required
-
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
?
|
||
The removed helper PHP will have to be added to the list of files to be deleted on update in script.php. I will do that when this PR has been merged.
@ditsuke I think @chmst indeed found an issue with your changed code, possibly here: https://github.com/joomla/joomla-cms/pull/36439/files#diff-b9f75ae33fad36d7a8968d12a2b78ec972c5e6d2c6fd7ed0024d764191ec48ecR572 .
Possibly a type cast to object is not sufficient. I don't have looked up now what the constructor expects.
@chmst @richard67 thanks for identifying the issue and the source! The latest commit should solve it. Please test.
You fixed the code error, but I don't understand why the Task Params are twice. First in tab "New Task" and in tab "Advanced"?
You fixed the code error, but I don't understand why the Task Params are twice. First in tab "New Task" and in tab "Advanced"?
@chmst I addressed that in #36515 (needs test). We need the routine parameter fieldset to have a showFront="true" attribute at the moment. Although I don't think that's ideal, this PR should work for now. Let's try to work on removing this requirement in the future!
Could we please get a couple tests on this
This pull request has automatically rebased to 4.2-dev.
This pull request has been automatically rebased to 5.0-dev.
This pull request has been automatically rebased to 5.1-dev.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
I have tested this item ? unsuccessfully on 4f91c6a
I opened an existing task, changed a setting, saved and closed and got a 500 error:
An error has occurred.
0 Class "Joomla\Component\Scheduler\Administrator\Model\ExecRuleHelper" not found
Call Stack
Function Location
1 () JROOT/administrator/components/com_scheduler/src/Model/TaskModel.php:571
2 Joomla\Component\Scheduler\Administrator\Model\TaskModel->save() JROOT/libraries/src/MVC/Controller/FormController.php:689
3 Joomla\CMS\MVC\Controller\FormController->save() JROOT/libraries/src/MVC/Controller/BaseController.php:730
4 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
5 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
6 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
7 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
8 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
9 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
10 require_once() JROOT/administrator/index.php:32
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36439.
@cybersalt same as this comment
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
Conflicting Files
PR-6.0-dev
Removed: ? |
||
I applied this patch and tried to change settings of a task:
When saving this settings:
PHP 8.0, win11 and xampp