Feeling Lucky
?
?
?
[#36397] - [4.0] Fix PHP 8.1 deprecation - strtolower null param
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 36397
- Diff
- PhilETaylor:php8-1
User tests: Successful: Unsuccessful:
Summary of Changes
Set sane default if the configuration.php has no value for dbtype, for example when running unit tests.
Testing Instructions
on a php 8.1 command line run
libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Date/DateTest.php
Actual result BEFORE applying this Pull Request
libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Date/DateTest.php
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.
...PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 60
PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 65
PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 78
PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 111
PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 116
.
Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 60
Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 65
Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 78
Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 111
Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Service/Provider/Database.php on line 116
...... 10 / 10 (100%)
Time: 52 ms, Memory: 10.00 MB
OK (10 tests, 32 assertions)
Expected result AFTER applying this Pull Request
libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Date/DateTest.php
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.
.......... 10 / 10 (100%)
Time: 57 ms, Memory: 10.00 MB
OK (10 tests, 32 assertions)
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Quy
- comment
- 16 Jan 2022
Please fix conflicts. Thanks.
PhilETaylor
- comment
- 16 Jan 2022
hmm on it thanks
| Labels |
Added:
Conflicting Files
?
|
||
PhilETaylor
- comment
- 16 Jan 2022
Done. Seems someone else did the same kind of thing, but this PR also cleans up the file and reduces the amount of code - so still has value.
| Labels |
Removed:
Conflicting Files
|
||
| Labels |
Added:
?
Removed: ? |
||
Quy
- comment
- 6 Mar 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36397.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 6 Mar 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36397.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:04 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on e5aa48f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36397.