Feeling Lucky
?
?
?
[#36396] - [4.0] PHP 8 Ensure that we have a valid date
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 36396
- Diff
- PhilETaylor:patch-312
User tests: Successful: Unsuccessful:
Code review
Symptoms:
<b>Deprecated</b>: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in <b>/tests/www/postgres/libraries/src/Date/Date.php</b> on line <b>126</b>
Unit test before PR
I mean, the provided unit test in this PR, before the change the Date.php
libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Date/DateTest.php
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.
..........PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Date/Date.php on line 126
. 11 / 11 (100%)
Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /Users/phil/Sites/joomla-cms/libraries/src/Date/Date.php on line 126
Time: 34 ms, Memory: 10.00 MB
OK (11 tests, 33 assertions)
Unit test after PR
libraries/vendor/bin/phpunit tests/Unit/Libraries/Cms/Date/DateTest.php
PHPUnit 8.5.21 by Sebastian Bergmann and contributors.
........... 11 / 11 (100%)
Time: 52 ms, Memory: 10.00 MB
OK (11 tests, 33 assertions)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
brianteeman
- comment
- 24 Dec 2021
such a short memory. it was only march this year
PhilETaylor
- comment
- 24 Dec 2021
Excuse me for forgetting which of the 3000+ contributions this year that was.. Ive probably slept since then
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
PhilETaylor
- comment
- 24 Dec 2021
Added a unit test that fails before PR and passes after PR
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 24 Dec 2021
Drone failure is unrelated to this PR content
alikon
- comment
- 29 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36396.
| Labels |
Added:
?
|
||
| Category | Libraries Unit Tests | ⇒ | Unit Tests |
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:34:01 |
| Closed_By | ⇒ | PhilETaylor |
That awkward moment when you go to check the unit tests on a class, and the whole class is full of your exact birth date/time LMAO - I guess I wrote these unit tests then or else someone is trolling me geek time...