? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
19 Dec 2021

Pull Request for Issue #36346 .

Summary of Changes

Send all the form data (although it's useless as you only need the changed id's for reordering) to the PHP

Testing Instructions

  • The core still works as before because it doesn't need any extra data

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 19 Dec 2021
avatar dgrammatiko dgrammatiko - change - 19 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Dec 2021
Category JavaScript Repository NPM Change
d88638c 19 Dec 2021 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 19 Dec 2021
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 19 Dec 2021

impossible to test

avatar dgrammatiko
dgrammatiko - comment - 19 Dec 2021

impossible to test

Well, we can confirm that the core still works as expected so that the core is not broken but these changes. The extra bits on the payload would be useful for devs doing things out of the core API and that's untestable but also should be ok if we didn't broke the core extensions...

avatar PhocaCz
PhocaCz - comment - 20 Dec 2021

To test it: Use browser with DevTools enabled (e.g. Google Chrome). Create articles and sort them. In DevTools switch to Network tab, to "Fetch/XHR" tab and see the AJAX results (see image):

img

When the patch is not applied, you will see only cid and order variable.

When the patch is applied, you will see more form data available. When you see them, you can mark this test as successfull.

Jan

avatar PhocaCz PhocaCz - test_item - 20 Dec 2021 - Tested successfully
avatar PhocaCz
PhocaCz - comment - 20 Dec 2021

I have tested this item successfully on d88638c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36353.

avatar jwaisner
jwaisner - comment - 3 Jan 2022

@dgrammatiko

Please update the PR to the latest branch.

avatar bembelimen bembelimen - change - 7 Jan 2022
Labels Added: ?
avatar dgrammatiko dgrammatiko - change - 3 Feb 2022
Labels Removed: ?
avatar dgrammatiko
dgrammatiko - comment - 1 Apr 2022

@bembelimen is there any interest for this one or should I close it?

avatar laoneo
laoneo - comment - 1 Apr 2022

I have tested this item successfully on 746b970


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36353.

avatar laoneo laoneo - test_item - 1 Apr 2022 - Tested successfully
avatar laoneo
laoneo - comment - 1 Apr 2022

image

avatar laoneo
laoneo - comment - 1 Apr 2022

Tested with reordering a module and the last screenshot is the request with all variables.

avatar laoneo laoneo - change - 1 Apr 2022
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 1 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36353.

avatar dgrammatiko
dgrammatiko - comment - 18 Apr 2022

@bembelimen any decision here?

avatar laoneo laoneo - change - 19 Apr 2022
Labels Added: ?
avatar roland-d roland-d - change - 22 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-22 19:19:30
Closed_By roland-d
avatar roland-d roland-d - close - 22 Apr 2022
avatar roland-d roland-d - merge - 22 Apr 2022
avatar roland-d
roland-d - comment - 22 Apr 2022

Thanks everybody.

avatar dgrammatiko
dgrammatiko - comment - 22 Apr 2022

Nice, that was my last pending PR, so good news for me

Add a Comment

Login with GitHub to post a comment