User tests: Successful: Unsuccessful:
Pull Request for Issue #36346 .
Send all the form data (although it's useless as you only need the changed id's for reordering) to the PHP
Works
Works
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
impossible to test
Well, we can confirm that the core still works as expected so that the core is not broken but these changes. The extra bits on the payload would be useful for devs doing things out of the core API and that's untestable but also should be ok if we didn't broke the core extensions...
To test it: Use browser with DevTools enabled (e.g. Google Chrome). Create articles and sort them. In DevTools switch to Network tab, to "Fetch/XHR" tab and see the AJAX results (see image):
When the patch is not applied, you will see only cid and order variable.
When the patch is applied, you will see more form data available. When you see them, you can mark this test as successfull.
Jan
I have tested this item
Please update the PR to the latest branch.
Labels |
Added:
?
|
Labels |
Removed:
?
|
@bembelimen is there any interest for this one or should I close it?
I have tested this item
Tested with reordering a module and the last screenshot is the request with all variables.
Status | Pending | ⇒ | Ready to Commit |
RTC
@bembelimen any decision here?
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-22 19:19:30 |
Closed_By | ⇒ | roland-d |
Thanks everybody.
Nice, that was my last pending PR, so good news for me
impossible to test