? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
18 Dec 2021

Pull Request for Issue #24343 .

Summary of Changes

The patch re-init an editor when the iframe moved around DOM.

Testing Instructions

Apply patch, run npm install
Please follow #24343

Or create subform with editor (example in Custom HTML):

<field type="subform" name="subform" multiple="true" label="subform">
  <form>
    <field type="editor" name="text" label="editor" buttons="false"  default="I am a text!"/>
  </form>
</field>

Add couple rows in subform and try sort them. Then watch editor content.

Actual result BEFORE applying this Pull Request

Content are gone.

Expected result AFTER applying this Pull Request

Content still there (can be with little delay)

Documentation Changes Required

None

avatar Fedik Fedik - open - 18 Dec 2021
avatar Fedik Fedik - change - 18 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2021
Category JavaScript Repository NPM Change
0ddd198 18 Dec 2021 avatar Fedik jscs
avatar Fedik Fedik - change - 18 Dec 2021
Labels Added: ? NPM Resource Changed
avatar Quy Quy - change - 1 Jun 2022
Labels Added: ?
Removed: ?
avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ?
avatar Quy Quy - change - 28 Jun 2022
Labels Added: ?
Removed: ?
avatar Fedik Fedik - change - 17 Jan 2023
Labels Removed: ?
avatar JonasAtZwetschke JonasAtZwetschke - test_item - 17 Jan 2023 - Tested successfully
avatar JonasAtZwetschke
JonasAtZwetschke - comment - 17 Jan 2023

I have tested this item successfully on 1007fe6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345.

avatar Quy Quy - change - 18 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345.

avatar Quy Quy - test_item - 18 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 18 Jan 2023

I have tested this item successfully on 1007fe6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36345.

avatar Quy Quy - change - 18 Jan 2023
Labels Added: ?
avatar roland-d roland-d - close - 19 Jan 2023
avatar roland-d roland-d - merge - 19 Jan 2023
avatar roland-d roland-d - change - 19 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-19 10:55:04
Closed_By roland-d
avatar roland-d
roland-d - comment - 19 Jan 2023

Thank you

avatar Quy
Quy - comment - 20 Jan 2023

@Fedik Please check why the editor loses focus when editing an article.

avatar Fedik
Fedik - comment - 20 Jan 2023

@Quy what wrong with focus? works fine for me

avatar Quy
Quy - comment - 20 Jan 2023

It is reloading between editor.min.css and content.min.css. Reverting this PR fixes the issue. Using Firefox 109.0 (64-bit.

36345

36345-editor

36345-network

avatar Fedik
Fedik - comment - 21 Jan 2023

I see, Firefox and Chrome handle iframe events diferently. I will check.

Add a Comment

Login with GitHub to post a comment