User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Run npm install
before applying this PR and make a copy of the media
folder
Apply this PR, run npm install
and compare the media
with the one you stored in the previous step. They should be identical (apart from the missing diff.min.js
and css/mejs-controls.png
which were removed upstream)
Check that the media manager works correctly: Double-clicking on a folder navigates to that folder
Some changes regarding the new Regex()
:
Check that editing the colour in the Atum template works as expected
Check that custom fields change context when selecting a different category
Check that installing extensions from the JED is working correctly
Check that Editing a user by changing the username and te password works as expected
Also check that all all npm commands still work
And finally confirm that CSS/JS is not broken, front end/ back end
No. @wilsonge @bembelimen after 4.0.5 could you have some people testing this one? Most dependencies are way behind...
Also please consider adding either dependabot or renovate bot so PRs are automatically created on each new update of any dependency
Status | New | ⇒ | Pending |
Category | ⇒ | Repository JavaScript NPM Change |
Labels |
Added:
?
NPM Resource Changed
|
Category | Repository JavaScript NPM Change | ⇒ | JavaScript Administration com_media NPM Change Repository |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-20 23:06:33 |
Closed_By | ⇒ | wilsonge |
@dgrammatiko The files '/media/vendor/diff/js/diff.min.js' and '/media/vendor/diff/js/diff.min.js.gz' are added to the list of deleted files and folders in script.php when I run my tool because now after this PR here has been merged, there is no minified and gzipped file anymore in the full package, but the unminified and unzipped '/media/vendor/diff/js/diff.js' file is in the package. Could you make a PR to fix that so that file is minified and gzipped again?
Or is it ok as it is and the files '/media/vendor/diff/js/diff.min.js' and '/media/vendor/diff/js/diff.min.js.gz' should be deleted on update?
@richard67 #36493 should bring back the minified file
Thanks!