? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
12 Dec 2021

Pull Request for Issue # .

Summary of Changes

  • Major versions update for few dependencies
  • Fixing the commander B/C breaks
  • Removed files from diff and mediaelement as the dist folder doesn't provide them

Testing Instructions

  • Run npm install before applying this PR and make a copy of the media folder

  • Apply this PR, run npm install and compare the media with the one you stored in the previous step. They should be identical (apart from the missing diff.min.js and css/mejs-controls.png which were removed upstream)

  • Check that the media manager works correctly: Double-clicking on a folder navigates to that folder

Some changes regarding the new Regex():

  • Check that editing the colour in the Atum template works as expected

  • Check that custom fields change context when selecting a different category

  • Check that installing extensions from the JED is working correctly

  • Check that Editing a user by changing the username and te password works as expected

  • Also check that all all npm commands still work

  • And finally confirm that CSS/JS is not broken, front end/ back end

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

No. @wilsonge @bembelimen after 4.0.5 could you have some people testing this one? Most dependencies are way behind...
Also please consider adding either dependabot or renovate bot so PRs are automatically created on each new update of any dependency

avatar dgrammatiko dgrammatiko - open - 12 Dec 2021
avatar dgrammatiko dgrammatiko - change - 12 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2021
Category Repository JavaScript NPM Change
b504a50 12 Dec 2021 avatar dgrammatiko nope
avatar dgrammatiko dgrammatiko - change - 12 Dec 2021
Labels Added: ? NPM Resource Changed
f3448a9 12 Dec 2021 avatar dgrammatiko CS
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2021
Category Repository JavaScript NPM Change JavaScript Administration com_media NPM Change Repository
b49889d 12 Dec 2021 avatar dgrammatiko comma
d369923 12 Dec 2021 avatar dgrammatiko oops
1e96880 12 Dec 2021 avatar dgrammatiko grrr
f3a02cc 12 Dec 2021 avatar dgrammatiko grrrr
avatar dgrammatiko dgrammatiko - change - 13 Dec 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 13 Dec 2021
avatar dgrammatiko dgrammatiko - change - 15 Dec 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 15 Dec 2021
avatar dgrammatiko dgrammatiko - change - 15 Dec 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 15 Dec 2021
avatar wilsonge wilsonge - change - 20 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-20 23:06:33
Closed_By wilsonge
avatar wilsonge wilsonge - close - 20 Dec 2021
avatar wilsonge wilsonge - merge - 20 Dec 2021
avatar wilsonge
wilsonge - comment - 20 Dec 2021

Thanks!

avatar richard67
richard67 - comment - 30 Dec 2021

@dgrammatiko The files '/media/vendor/diff/js/diff.min.js' and '/media/vendor/diff/js/diff.min.js.gz' are added to the list of deleted files and folders in script.php when I run my tool because now after this PR here has been merged, there is no minified and gzipped file anymore in the full package, but the unminified and unzipped '/media/vendor/diff/js/diff.js' file is in the package. Could you make a PR to fix that so that file is minified and gzipped again?

avatar richard67
richard67 - comment - 30 Dec 2021

Or is it ok as it is and the files '/media/vendor/diff/js/diff.min.js' and '/media/vendor/diff/js/diff.min.js.gz' should be deleted on update?

avatar dgrammatiko
dgrammatiko - comment - 30 Dec 2021

@richard67 #36493 should bring back the minified file

Add a Comment

Login with GitHub to post a comment