[#36293] - [4.0.5 RC-4] PHP 8.1 compat
- Closed
- 14 Dec 2021
- Medium
- Build: 4.0-dev
- # 36293
Additional comments
It doesn't look like the updated framework made it to 4.0.5 RC-4
PR #36248 is also essential to avoid crash with error reporting enabled.
Correction: Nightly build has updated framework and run without this PR.
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
PRs exist already: maximebf/php-debugbar#489 and maximebf/php-debugbar#467
As you can probably see from commit history I did a large round of fixes last night, merging others fixes and merging in the framework fixes.
I'm not coming close to pretending I've fixed all the deprecation warnings - most pages will still have a couple. But they should still work.
I don't realistically see us fixing all of them before the release on Tuesday - especially as noted that several of them depend on upstream dependencies to make a release.
We do best efforts for this release (and practically in a production setup that should be good enough anyhow even though far from ideal). And just keep pushing on at other deprecation issues for the next release in January.
| Title |
|
||||||
no problem
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-14 09:14:52 |
| Closed_By | ⇒ | frostmakk |
4.0.5 is out, and running with maximum error reporting enabled on PHP 8.1, so closing this.
with debug mode enabled with Php 8.1.0 there are plenty of deprecated messages from debug bar :
Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\JavascriptRenderer.php on line 792Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\JavascriptRenderer.php on line 792Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\JavascriptRenderer.php on line 808Deprecated: Implicit conversion from float -INF to int loses precision in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\DataFormatter\DataFormatter.php on line 81Deprecated: Return type of DebugBar\DebugBar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\DebugBar.php on line 484Deprecated: Return type of DebugBar\DebugBar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\DebugBar.php on line 479Deprecated: Return type of DebugBar\DebugBar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\DebugBar.php on line 474Deprecated: Return type of DebugBar\DebugBar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Users\xillibit\git\joomla-cms-40-dev\libraries\vendor\maximebf\debugbar\src\DebugBar\DebugBar.php on line 489I think it should be fixed in upstream