? Pending

User tests: Successful: Unsuccessful:

avatar frostmakk
frostmakk
11 Dec 2021

Pull Request for Issue # .

Summary of Changes

Silencing PHP 8.1 deprecation notices.
Not sure if this is the best approach at the moment, but at least there will be a searchable "label" for things that needs looking into later.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Deprecated: Return type of Joomla\CMS\Feed\Feed::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /********/src/libraries/src/Feed/Feed.php on line 194

Deprecated: Return type of Joomla\CMS\Feed\Feed::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /********/src/libraries/src/Feed/Feed.php on line 210

Deprecated: Return type of Joomla\CMS\Feed\Feed::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /********/src/libraries/src/Feed/Feed.php on line 225

Deprecated: Return type of Joomla\CMS\Feed\Feed::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /********/src/libraries/src/Feed/Feed.php on line 242

Deprecated: Return type of Joomla\CMS\Feed\Feed::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /********/src/libraries/src/Feed/Feed.php on line 270

Expected result AFTER applying this Pull Request

No PHP 8.1 deprecation notices from Feed

Documentation Changes Required

Probably not

avatar frostmakk frostmakk - open - 11 Dec 2021
avatar frostmakk frostmakk - change - 11 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Dec 2021
Category Libraries
avatar wilsonge wilsonge - change - 11 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-11 18:34:09
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Dec 2021
avatar wilsonge wilsonge - merge - 11 Dec 2021
avatar wilsonge
wilsonge - comment - 11 Dec 2021

Thanks!

Add a Comment

Login with GitHub to post a comment