? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
10 Dec 2021

Pull Request for Issue # .

  • PHP Deprecated: Declaration of Joomla\CMS\Date\Date::format($format, $local = false, $translate = true) should be compatible with DateTime::format(string $format): string in ../joomla-cms/libraries/src/Date/Date.php
  • PHP Deprecated: Declaration of Joomla\CMS\Date\Date::setTimezone($tz) should be compatible with DateTime::setTimezone(DateTimeZone $timezone): DateTime in ../joomla-cms/libraries/src/Date/Date.php

Summary of Changes

added annotation #[\ReturnTypeWillChange]

avatar alikon alikon - open - 10 Dec 2021
avatar alikon alikon - change - 10 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Dec 2021
Category Libraries
avatar Fedik
Fedik - comment - 10 Dec 2021

Unfortunately it will lead to Fatal error, for everyone who extends our Date class.
We need a better idea, how to solve it.

avatar alikon alikon - change - 10 Dec 2021
Labels Added: ?
avatar wilsonge
wilsonge - comment - 10 Dec 2021

For J4 we're just going to have to add the annotations. As mentioned this is a b/c break for anything extending these classes. Annotations should work back to PHP 7.2 as well.

avatar alikon alikon - change - 10 Dec 2021
The description was changed
avatar alikon alikon - edited - 10 Dec 2021
3caff70 11 Dec 2021 avatar alikon tab
avatar wilsonge wilsonge - change - 11 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-11 18:30:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 11 Dec 2021
avatar wilsonge wilsonge - merge - 11 Dec 2021
avatar wilsonge
wilsonge - comment - 11 Dec 2021

Thanks!

Add a Comment

Login with GitHub to post a comment