Feeling Lucky
?
?
[#36281] - [4] cannot pass null to trim function in php 8.1
- Fixed in Code Base
- 11 Dec 2021
- Medium
- Build: 4.0-dev
- # 36281
- Diff
- alikon:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
set a default value
Testing Instructions
open admin
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
no Exception
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
alikon
- comment
- 10 Dec 2021
sound better now ?
HLeithner
- comment
- 10 Dec 2021
thanks
Krshivam25
- comment
- 10 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.
xillibit
- comment
- 10 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 10 Dec 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.
Quy
- comment
- 10 Dec 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-11 18:31:08 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 11 Dec 2021
Thanks!
please stop adding
?? ''blindly everywhere you seeing this error.For example in this case we take the variable 2 lines above, so being sure that a string is returned should bin in this line.
Beside that
trim($xxx ?? '');looks ugly and doesn't explain why we expect an empty variable at this point in the code. Please a proper if statement above and explain with a comment why it could beNULL(if it's not logical)