? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
10 Dec 2021

Pull Request for Issue # .

Summary of Changes

set a default value

Testing Instructions

open admin

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

no Exception

avatar alikon alikon - open - 10 Dec 2021
avatar alikon alikon - change - 10 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Dec 2021
Category Libraries
avatar HLeithner
HLeithner - comment - 10 Dec 2021

please stop adding ?? '' blindly everywhere you seeing this error.

For example in this case we take the variable 2 lines above, so being sure that a string is returned should bin in this line.

Beside that trim($xxx ?? ''); looks ugly and doesn't explain why we expect an empty variable at this point in the code. Please a proper if statement above and explain with a comment why it could be NULL (if it's not logical)

avatar alikon alikon - change - 10 Dec 2021
Labels Added: ?
avatar alikon
alikon - comment - 10 Dec 2021

sound better now ?

avatar HLeithner
HLeithner - comment - 10 Dec 2021

thanks

avatar Krshivam25 Krshivam25 - test_item - 10 Dec 2021 - Tested successfully
avatar Krshivam25
Krshivam25 - comment - 10 Dec 2021

I have tested this item successfully on fb7a29d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.

avatar xillibit xillibit - test_item - 10 Dec 2021 - Tested successfully
avatar xillibit
xillibit - comment - 10 Dec 2021

I have tested this item successfully on fb7a29d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.

avatar Quy Quy - change - 10 Dec 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.

avatar Quy
Quy - comment - 10 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36281.

avatar wilsonge wilsonge - close - 11 Dec 2021
avatar wilsonge wilsonge - merge - 11 Dec 2021
avatar wilsonge wilsonge - change - 11 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-11 18:31:08
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 11 Dec 2021

Thanks!

Add a Comment

Login with GitHub to post a comment