User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
sound better now ?
thanks
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-11 18:31:08 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
please stop adding
?? ''
blindly everywhere you seeing this error.For example in this case we take the variable 2 lines above, so being sure that a string is returned should bin in this line.
Beside that
trim($xxx ?? '');
looks ugly and doesn't explain why we expect an empty variable at this point in the code. Please a proper if statement above and explain with a comment why it could beNULL
(if it's not logical)