Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36251] - [4.1][bugfix] Assets should be loaded in the layout

? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
7 Dec 2021

Pull Request for Issue # .

Summary of Changes

Moved a call for including some JS from the HTML file to the actual layout

Testing Instructions

Test editing the system settings in the front end.
Ensure that inline help still works as expected

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

No, it's a bug as it forces a script that can only be disabled with a plugin (in the layout anyone can just add/remove whatever they want, not forced!!!)

avatar dgrammatiko dgrammatiko - open - 7 Dec 2021
avatar dgrammatiko dgrammatiko - change - 7 Dec 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2021
Category ⇒ Front End com_config
avatar Quy Quy - test_item - 7 Dec 2021 - Tested successfully
avatar Quy
Quy - comment - 7 Dec 2021

I have tested this item ✅ successfully on 3a91e85

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36251.

avatar jwaisner jwaisner - test_item - 13 Dec 2021 - Tested successfully
avatar jwaisner
jwaisner - comment - 13 Dec 2021

I have tested this item ✅ successfully on 3a91e85

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36251.

avatar jwaisner jwaisner - test_item - 13 Dec 2021 - Not tested
avatar jwaisner
jwaisner - comment - 13 Dec 2021

I have not tested this item.

Holding off on result as the PR is out of sync with the base branch.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36251.

avatar jwaisner
jwaisner - comment - 13 Dec 2021

@dgrammatiko ,

Can you update this PR so testing can occur with the latest branch?

avatar RickR2H RickR2H - test_item - 15 Dec 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 15 Dec 2021

I have tested this item ✅ successfully on 3a91e85

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36251.

avatar RickR2H RickR2H - change - 15 Dec 2021
Status Pending ⇒ Ready to Commit
avatar RickR2H
RickR2H - comment - 15 Dec 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36251.

avatar bembelimen bembelimen - close - 16 Dec 2021
avatar bembelimen bembelimen - merge - 16 Dec 2021
avatar bembelimen bembelimen - change - 16 Dec 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-12-16 10:56:17
Closed_By ⇒ bembelimen
Labels Added: ? ?
avatar bembelimen
bembelimen - comment - 16 Dec 2021

Thx

Add a Comment

Login with GitHub to post a comment