? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
7 Dec 2021

Pull Request for Issue #36216 (comment) .

Summary of Changes

  • Adds a select element in the child template creation modal where users can pick any of the existing parent template's styles.
  • The first option (Default) means: apply the existing params from the parent XML file (default)

Screenshot 2021-12-07 at 10 43 23

Screenshot 2021-12-07 at 10 43 17

Testing Instructions

  • Create a new style for Cassiopeia or Atum (give it some distinct name)
  • Try to create a child templates with Default and with the new style you created before
  • Compare that the options in the child are the same as the parent template (the one you created/selected)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

In addition to the docs for the child templates

@bembelimen @brianteeman

avatar dgrammatiko dgrammatiko - open - 7 Dec 2021
avatar dgrammatiko dgrammatiko - change - 7 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2021
Category Administration com_templates Language & Strings
avatar bembelimen
bembelimen - comment - 7 Dec 2021

If we offer this option, it should be a multiple select I think (fancy select + required)

PS: the button in the model should be "Create" (bottom right)

avatar dgrammatiko
dgrammatiko - comment - 7 Dec 2021

PS: the button in the model should be "Create" (bottom right)

Brian has a PR for this #36228

it should be a multiple select I think

We can only apply one existing style to the child or am I getting this wrong?

avatar dgrammatiko dgrammatiko - change - 7 Dec 2021
Labels Added: Language Change ?
avatar bembelimen
bembelimen - comment - 7 Dec 2021

it should be a multiple select I think

We can only apply one existing style to the child or am I getting this wrong?

I think so, you can copy any style, as the child is a "normal" template you can have multiple

avatar brianteeman
brianteeman - comment - 7 Dec 2021

PS: the button in the model should be "Create" (bottom right)

Brian has a PR for this #36228

Yes please merge that for the beta as it will make things a little easier to understand

avatar dgrammatiko
dgrammatiko - comment - 7 Dec 2021

I think so, you can copy any style, as the child is a "normal" template you can have multiple

Ok but that's a different thing than what the code is actually doing here. Let me explain: When the child is installed it creates a default style based on the values of the XML file. The select element here just overrides these values to the ones from the parent template style that was selected (if something other than default was selected).

Creating additional styles is possible but what would be the titles for them? (prepend them with the child name and removing the parent from the string could be an option). Anyways that would be probably an extra select element

avatar dgrammatiko
dgrammatiko - comment - 7 Dec 2021

@bembelimen @brianteeman I'm not sure if this is what you were asking for but now a user could freely select styles from the parent or any child from the same parent

Screenshot 2021-12-07 at 21 03 37
Screenshot 2021-12-07 at 21 03 13

Screenshot 2021-12-07 at 21 20 01

avatar akshitrattan
akshitrattan - comment - 10 Jan 2022

I have successfully tested the issue.
I was able to create a child template and it had the same configuration as the parent template.
Screenshot 2022-01-10 at 1 07 52 PM
Screenshot 2022-01-10 at 1 05 35 PM
This is the only difference
P.S:- cassieopia_wow is the child template

avatar pritam825
pritam825 - comment - 10 Jan 2022

I have tested this item successfully on 89ff152


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

avatar pritam825 pritam825 - test_item - 10 Jan 2022 - Tested successfully
avatar akshitrattan
akshitrattan - comment - 10 Jan 2022

I have tested this item successfully on 89ff152

I have successfully tested the issue.
I was able to create a child template and it had the same configuration as the parent template.
All the styles (CSS, HTML, and js files) of the parent template were included in the directory for the child template as well


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

avatar akshitrattan akshitrattan - test_item - 10 Jan 2022 - Tested successfully
686e9eb 10 Jan 2022 avatar dgrammatiko txt
avatar rjharishabh
rjharishabh - comment - 11 Jan 2022

Hi @pritam825 @akshitrattan , can you please test this once again?
Sorry for the inconvenience.

avatar pritam825
pritam825 - comment - 11 Jan 2022

@rjharishabh Yes Sure

avatar pritam825
pritam825 - comment - 11 Jan 2022

I am able to create the child template successfully and it has the same configuration as parent
test

check_again is the child template

avatar pritam825
pritam825 - comment - 11 Jan 2022

I have tested this item successfully on 686e9eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

avatar pritam825 pritam825 - test_item - 11 Jan 2022 - Tested successfully
ad86e38 11 Jan 2022 avatar dgrammatiko oops
avatar dgrammatiko
dgrammatiko - comment - 16 Mar 2022

@bembelimen is there still any interest for this or should I close it?

avatar bembelimen
bembelimen - comment - 17 Mar 2022

Sure, we just need the tests.

avatar RickR2H
RickR2H - comment - 22 Mar 2022

I have tested this item successfully on ad86e38

Test was successful! But we need some solid docs on explaining why you can choose multiple style which is essence makes no sense in the context of creating a child theme.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

avatar RickR2H RickR2H - test_item - 22 Mar 2022 - Tested successfully
avatar ricardo1709
ricardo1709 - comment - 22 Mar 2022

I have tested this item successfully on ad86e38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

avatar ricardo1709 ricardo1709 - test_item - 22 Mar 2022 - Tested successfully
avatar RickR2H RickR2H - change - 22 Mar 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 22 Mar 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36250.

avatar laoneo laoneo - change - 4 Apr 2022
Labels Added: ?
avatar laoneo laoneo - change - 4 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-04 14:26:59
Closed_By laoneo
avatar laoneo laoneo - close - 4 Apr 2022
avatar laoneo laoneo - merge - 4 Apr 2022
avatar laoneo
laoneo - comment - 4 Apr 2022

Thanks!

avatar infograf768
infograf768 - comment - 5 Apr 2022

Please see

#37485

Add a Comment

Login with GitHub to post a comment