User tests: Successful: Unsuccessful:
Pull Request for Issue #36216 (comment) .
In addition to the docs for the child templates
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_templates Language & Strings |
Labels |
Added:
Language Change
?
|
it should be a multiple select I think
We can only apply one existing style to the child or am I getting this wrong?
I think so, you can copy any style, as the child is a "normal" template you can have multiple
I think so, you can copy any style, as the child is a "normal" template you can have multiple
Ok but that's a different thing than what the code is actually doing here. Let me explain: When the child is installed it creates a default style based on the values of the XML file. The select element here just overrides these values to the ones from the parent template style that was selected (if something other than default was selected).
Creating additional styles is possible but what would be the titles for them? (prepend them with the child name and removing the parent from the string could be an option). Anyways that would be probably an extra select element
@bembelimen @brianteeman I'm not sure if this is what you were asking for but now a user could freely select styles from the parent or any child from the same parent
I have tested this item
I have tested this item
I have successfully tested the issue.
I was able to create a child template and it had the same configuration as the parent template.
All the styles (CSS, HTML, and js files) of the parent template were included in the directory for the child template as well
Hi @pritam825 @akshitrattan , can you please test this once again?
Sorry for the inconvenience.
@rjharishabh Yes Sure
I have tested this item
@bembelimen is there still any interest for this or should I close it?
Sure, we just need the tests.
I have tested this item
Test was successful! But we need some solid docs on explaining why you can choose multiple style which is essence makes no sense in the context of creating a child theme.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-04 14:26:59 |
Closed_By | ⇒ | laoneo |
Thanks!
If we offer this option, it should be a multiple select I think (fancy select + required)
PS: the button in the model should be "Create" (bottom right)