Language Change ? ? Pending

User tests: Successful: Unsuccessful:

avatar AJAY007L
AJAY007L
5 Dec 2021

Pull Request for Issue #35467.

Summary of Changes

    Removed popovers on the 'title' in Category list.        

Testing Instructions

    Head over to http://localhost/joomla-cms/index.php/article-category-list after installing sample data.

Actual result BEFORE applying this Pull Request

131897635-fbc014c6-d871-4458-913e-3b7dfee86a75

Expected result AFTER applying this Pull Request

WhatsApp Image 2021-12-05 at 16 22 59

Documentation Changes Required

   none.
ec1c7a8 1 Dec 2021 avatar test
4314a27 1 Dec 2021 avatar test
avatar AJAY007L AJAY007L - open - 5 Dec 2021
avatar AJAY007L AJAY007L - change - 5 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2021
Category Libraries
avatar chmst
chmst - comment - 5 Dec 2021

@AJAY007L thanks for your contribution and working on that issue.
But we don't use titles in headers as you can see in backend overviews. Users see already the headline (or hear it if they are blind). The purpose if the information is: Say the user that he can order the table with a click on the link. In a way which is a11y (popovers are not).

So adding a title is not the right solution here. If you like to work on this - try understanding tooltips ;)

avatar AJAY007L
AJAY007L - comment - 5 Dec 2021

Now, I understood what you want to say. @chmst Thanks for the reply.

avatar AJAY007L AJAY007L - change - 6 Dec 2021
Labels Added: ?
avatar AJAY007L
AJAY007L - comment - 7 Dec 2021

@chmst I made some changes in the code . Now, People can see or hear the link functionality of sorting the column.

***After change in code
https://user-images.githubusercontent.com/60544908/144995602-3bd3f459-0e1e-49fa-8d98-01af6a8d151a.mp4

avatar ceford
ceford - comment - 7 Dec 2021

It works but is it the right solution? Should the Tooltip be there at all? Sighted users just have to know that clicking a heading will sort by that column?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36202.

avatar AJAY007L
AJAY007L - comment - 7 Dec 2021

Sir, I removed the tooltip and the rest is the same.

After Change in code

fixed.mp4
avatar richard67
richard67 - comment - 7 Dec 2021

@AJAY007L Could you fix the code style errors reported here? https://ci.joomla.org/joomla/joomla-cms/49027/1/6
Thanks in advance.

avatar Quy
Quy - comment - 7 Dec 2021

Please read #33107 as this is not the correct fix.

avatar brianteeman brianteeman - test_item - 7 Dec 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 7 Dec 2021

I have tested this item ? unsuccessfully on e50bc9b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36202.

avatar brianteeman
brianteeman - comment - 7 Dec 2021
  1. Document has multiple elements referenced with ARIA with the same id attribute: desc
  2. Hardcoded language string
  3. Unused data-bs-content
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2021
Category Libraries Language & Strings Libraries
f3de126 9 Dec 2021 avatar fix
avatar AJAY007L AJAY007L - change - 9 Dec 2021
Labels Added: Language Change
avatar brianteeman
brianteeman - comment - 10 Dec 2021

Please read #33107 as this is not the correct fix.

Also there is no need for a new string as we already have JGLOBAL_CLICK_TO_SORT_THIS_COLUMN

avatar chmst chmst - change - 31 Jan 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 22 Jun 2022

This should be closed as an abandoned pr AND completely the wrong approach as already detailed

avatar Quy Quy - change - 22 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-22 14:34:50
Closed_By Quy
Labels Added: ?
Removed: ?
avatar Quy Quy - close - 22 Jun 2022

Add a Comment

Login with GitHub to post a comment