No Code Attached Yet
avatar PhilETaylor
PhilETaylor
4 Dec 2021

Im concerned about the large amount of @todo tags that were still in the com_scheduler when it was merged, and now that it is merged, there doesn't seem to be any plan to address these.

This is adding considerable technical debt in a feature that is not even released yet.

@ditsuke

An even scary @joomla/security @todocomment in plugins/task/requests/requests.php

// @todo this handling must be rethought and made safe. stands as a good demo right now.
		$responseFilename = Path::clean(JPATH_ROOT . "/tmp/task_{$id}_response.html");

There are 34 @todo tags in /administrator/components/com_scheduler alone.

Screenshot 2021-12-04 at 19 12 16

avatar PhilETaylor PhilETaylor - open - 4 Dec 2021
avatar joomla-cms-bot joomla-cms-bot - change - 4 Dec 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Dec 2021
avatar PhilETaylor PhilETaylor - change - 4 Dec 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 4 Dec 2021
avatar PhilETaylor PhilETaylor - change - 4 Dec 2021
Title
[4.1] Tasks Scheduler `@Todo` ?
[4.1] Tasks Scheduler, 35 x `@Todo` ?
avatar PhilETaylor PhilETaylor - edited - 4 Dec 2021
avatar ditsuke
ditsuke - comment - 4 Dec 2021

Thanks for tagging. I have my exams at Uni at the moment, but I plan on addressing the todos and some other things later in December when I'm free.

avatar richard67
richard67 - comment - 8 Dec 2021

@ditsuke All the best wishes for your exams.

avatar PhilETaylor PhilETaylor - change - 7 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-07 18:36:16
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 7 Mar 2022

Add a Comment

Login with GitHub to post a comment