? Release Blocker ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
1 Dec 2021

Pull Request for Issue # .

Summary of Changes

Recent changes in BS have some sharing code from Alert and Modal for other components. Since Joomla is not distributing a monolith for the JS the build script had to be informed.

EDIT: What happen: The Alert and Modal are now using common code for the close button that lives in the js/src/util/... https://github.com/twbs/bootstrap/blob/main/js/src/util/component-functions.js
as it can be clearly seen in https://github.com/twbs/bootstrap/blob/d8999dd5666336dcf6976cc65bc0d562a4baec5a/js/src/alert.js#L11 and https://github.com/twbs/bootstrap/blob/d8999dd5666336dcf6976cc65bc0d562a4baec5a/js/src/modal.js#L23
To prevent such changes breaking the builds, the build script will automatically add any files in the src/js/dom and src/js/util to the external scripts and create a chunk with all of them ./dom.js. This should be future proof as it doesn't have any of these imports hardcoded...

Testing Instructions

  • A broken example that you can test is #36169
  • But also a simple check before and after on the network waterfall is enough:
    • Before, double entries for alert+modal

Screenshot 2021-12-01 at 17 58 51

    • After, no double entries

Screenshot 2021-12-01 at 17 57 01

Actual result BEFORE applying this Pull Request

Screenshot 2021-12-01 at 17 58 51

Expected result AFTER applying this Pull Request

Documentation Changes Required

@wilsonge this is a release blocker

avatar dgrammatiko dgrammatiko - open - 1 Dec 2021
avatar dgrammatiko dgrammatiko - change - 1 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Dec 2021
Category JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 1 Dec 2021
Labels Added: ?
avatar richard67
richard67 - comment - 1 Dec 2021

Does this solve issue #36169 ?

avatar dgrammatiko
dgrammatiko - comment - 1 Dec 2021

@richard67 yes, both #36169 and #36176 are just side effects of double imports

avatar richard67
richard67 - comment - 1 Dec 2021

@dgrammatiko Then you should refer to the issues at the top of the PR, „Pull request for issue #36169 and #36176 “ so we can know that. Otherwise issues will remain open forever after PR has been merged because nobody knows there was a PR which solved them.

avatar PhocaCz
PhocaCz - comment - 1 Dec 2021

I have tested this item successfully on 2d8cef3

Tested successfully. Both (Link, Button) close window properly including deleting modal-backdrop (only one instance created).

Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36178.
avatar PhocaCz PhocaCz - test_item - 1 Dec 2021 - Tested successfully
avatar dgrammatiko dgrammatiko - change - 1 Dec 2021
Labels Added: Release Blocker
9d7eae6 1 Dec 2021 avatar dgrammatiko CS
ac1c53c 1 Dec 2021 avatar dgrammatiko CS
avatar dgrammatiko
dgrammatiko - comment - 2 Dec 2021

@PhocaCz can you please re test this one.

avatar PhocaCz
PhocaCz - comment - 2 Dec 2021

I have tested this item successfully on ac1c53c

Retested again, it looks OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36178.

avatar PhocaCz PhocaCz - test_item - 2 Dec 2021 - Tested successfully
avatar dgrammatiko dgrammatiko - change - 2 Dec 2021
The description was changed
avatar dgrammatiko dgrammatiko - edited - 2 Dec 2021
avatar ceford
ceford - comment - 2 Dec 2021

I have tested this item successfully on ac1c53c

I did the test as described in #36169. This PR does not mention NPM Resource Change - I guess that is just an oversight.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36178.

avatar ceford ceford - test_item - 2 Dec 2021 - Tested successfully
avatar richard67 richard67 - change - 2 Dec 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36178.

avatar khu5h1
khu5h1 - comment - 4 Dec 2021

I have tested this item successfully on ac1c53c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36178.

avatar khu5h1 khu5h1 - test_item - 4 Dec 2021 - Tested successfully
avatar pritam825
pritam825 - comment - 4 Dec 2021

I have tested this item successfully on ac1c53c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36178.

avatar pritam825 pritam825 - test_item - 4 Dec 2021 - Tested successfully
avatar wilsonge wilsonge - close - 5 Dec 2021
avatar wilsonge wilsonge - merge - 5 Dec 2021
avatar wilsonge wilsonge - change - 5 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-05 17:20:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 5 Dec 2021

Thanks!

Add a Comment

Login with GitHub to post a comment