User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Recent changes in BS have some sharing code from Alert
and Modal
for other components. Since Joomla is not distributing a monolith for the JS the build script had to be informed.
EDIT: What happen: The Alert and Modal are now using common code for the close button that lives in the js/src/util/...
https://github.com/twbs/bootstrap/blob/main/js/src/util/component-functions.js
as it can be clearly seen in https://github.com/twbs/bootstrap/blob/d8999dd5666336dcf6976cc65bc0d562a4baec5a/js/src/alert.js#L11 and https://github.com/twbs/bootstrap/blob/d8999dd5666336dcf6976cc65bc0d562a4baec5a/js/src/modal.js#L23
To prevent such changes breaking the builds, the build script will automatically add any files in the src/js/dom
and src/js/util
to the external scripts and create a chunk with all of them ./dom.js
. This should be future proof as it doesn't have any of these imports hardcoded...
@wilsonge this is a release blocker
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository |
Labels |
Added:
?
|
@richard67 yes, both #36169 and #36176 are just side effects of double imports
@dgrammatiko Then you should refer to the issues at the top of the PR, „Pull request for issue #36169 and #36176 “ so we can know that. Otherwise issues will remain open forever after PR has been merged because nobody knows there was a PR which solved them.
I have tested this item
Tested successfully. Both (Link, Button) close window properly including deleting modal-backdrop (only one instance created).
Thank you.
Labels |
Added:
Release Blocker
|
I have tested this item
Retested again, it looks OK.
I have tested this item
I did the test as described in #36169. This PR does not mention NPM Resource Change - I guess that is just an oversight.
Status | Pending | ⇒ | Ready to Commit |
RTC
I have tested this item
I have tested this item
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-05 17:20:34 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Does this solve issue #36169 ?