Feeling Lucky
?
?
NPM Resource Changed
[#36155] - [4.0] media manager infobar
- Fixed in Code Base
- 29 Dec 2021
- Medium
- Build: 4.0-dev
- # 36155
- Diff
- brianteeman:media_manager_rtl_infobar
User tests: Successful: Unsuccessful:
The RTL specific css was wrong as can be seen in the before screenshot -having a seperate block of css for rtl or even worse a separate file makes this sort of thing all too easy to happen.
This PR removes the RTL specific css (should have been scss) and updates the scss to use logical properties instead.
To test RTL you will need to install arabic or persian.
and dont forget to npm ci
There is no visible change in LTR and the RTL changes are as shown below
Before LTR
Before RTL
After LTR
After RTL
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
pritam825
- comment
- 2 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36155.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 2 Dec 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36155.
khu5h1
- comment
- 4 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36155.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-29 16:13:57 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 29 Dec 2021
Thanks
brianteeman
- comment
- 29 Dec 2021
thanks
I have tested this item✅ successfully on 9a037d5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36155.