Feeling Lucky
?
?
NPM Resource Changed
[#36154] - [4.0] media manager breadcrumbs
- Fixed in Code Base
- 2 Jan 2022
- Medium
- Build: 4.0-dev
- # 36154
- Diff
- brianteeman:media_manager_rtl_breadcrumb
User tests: Successful: Unsuccessful:
The RTL specific css was wrong as can be seen in the before screenshot
This PR removes the RTL specific css (should have been scss) and updates the scss to use logical properties instead.
This PR also removes an unused class breadcrumb-item.
To test RTL you will need to install arabic or persian.
and dont forget to npm ci
There is no visible change in LTR and the RTL changes are as shown below
Before LTR
Before RTL
After LTR
After RTL
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
pritam825
- comment
- 2 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36154.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
?
|
||
richard67
- comment
- 2 Dec 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36154.
khu5h1
- comment
- 4 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36154.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-02 18:44:31 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 2 Jan 2022
Thanks
I have tested this item✅ successfully on 0f09661
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36154.