? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Nov 2021

This PR removes code that was required in joomla 3 when the admin menu was horizontal. Now that it is vertical there is no need for this code at all.

To test ensure that the admin menu works and looks the same as before the PR with an RTL language such as arabic or persian

avatar brianteeman brianteeman - open - 28 Nov 2021
avatar brianteeman brianteeman - change - 28 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2021
Category Modules Administration
avatar khu5h1 khu5h1 - test_item - 29 Nov 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 29 Nov 2021

I have tested this item successfully on 320d2b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36147.

avatar ceford
ceford - comment - 29 Nov 2021

I have tested this item successfully on 320d2b8

Seems fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36147.

avatar ceford ceford - test_item - 29 Nov 2021 - Tested successfully
avatar Quy Quy - change - 29 Nov 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 29 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36147.

avatar infograf768
infograf768 - comment - 30 Nov 2021

Does not solve admin menu RTL the issue in Safari.
See: #36143 (comment)

avatar brianteeman
brianteeman - comment - 30 Nov 2021

@infograf768 no it doesnt solve that because it is nothing to do with it

avatar wilsonge wilsonge - close - 29 Dec 2021
avatar wilsonge wilsonge - merge - 29 Dec 2021
avatar wilsonge wilsonge - change - 29 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-29 01:41:22
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 29 Dec 2021

Thanks!

avatar brianteeman
brianteeman - comment - 29 Dec 2021

thanks

Add a Comment

Login with GitHub to post a comment