[#36146] - [4.0] Article Manager RTL correction
- Closed
- 20 Apr 2022
- Medium
- Build: 4.0-dev
- # 36146
- Diff
- brianteeman:more_rtl_content
User tests: Successful: Unsuccessful:
This PR removes a conditional block from the article manager and the featured article manager that was intended to ensure that the display of the category and nested category was correct when the admin is using an rtl language and the category names may be a mix of LTR and RTL.
Not really sure why but
- this code does not work correctly. the order of the categories is wrong and the << character is wrong
- there is no need for this alternate block of code for RTL
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Labels |
Added:
?
|
||
For some reason, with or without the patch applied, with Persian as the admin language I see Persian text embedded in the Category name. also containing a colon:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36146.
thats the word category in persian
I do not get the same result as the screenshots above. Never gets 2 « before or after patch.
Missing instructions: what is the sub category to which is assigned the article in the original description ?
In the sample below, the parent is Kategorie(de-de) and I created a subcategory in which I moved the article.
BEFORE PATCH , RTL
AFTER PATCH
RTL
LTR
Is it what is expected? If yes, patch looks good.
I am guessing that your categories are
Kategorie (de-de)
- مجموعه whatever (fa-ir)
If so then your screenshots show the expected results and a faulty before shot
Not sure what you mean about a second «
@infograf768 please can you respond
@infograf768 please explain what the problem is as your comment is blocking this being merged
Read again:
Is it what is expected? If yes, patch looks good.
I just remarked a wrong description of the issue. You wrote:
this code does not work correctly. the order of the categories is wrong and the << character is wrong
instead of and the « character is wrong
Ah you're playing your silly games again. Never mind I will just close it.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-19 08:14:04 |
| Closed_By | ⇒ | brianteeman |
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-01-19 08:14:04 | ⇒ | |
| Closed_By | brianteeman | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-04-20 17:03:14 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
For some reason, with or without the patch applied, with Persian as the admin language I see Persian text embedded in the Category name. also containing a colon:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36146.