Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36140] - Fix Codemirror behind tabs

? ? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
28 Nov 2021

Pull Request for Issue #35096 .

Summary of Changes

Use IntersectionObserver to refresh Codemirror when it become visible

Testing Instructions

Apply patch, run npm install.
Add editor somewhere in hidden tab, example to Custom HTML module :

<field type="editor" name="editor_test" editor="codemirror" label="editor test" default="I am a text!"/>

Visit the module form, and click on tab with this editor.

Actual result BEFORE applying this Pull Request

Editor is empty

Expected result AFTER applying this Pull Request

Editor should display a default text.

Documentation Changes Required

none

avatar Fedik Fedik - open - 28 Nov 2021
avatar Fedik Fedik - change - 28 Nov 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2021
Category ⇒ JavaScript Repository NPM Change
4a9e06f 28 Nov 2021 avatar Fedik jscs
avatar Fedik Fedik - change - 28 Nov 2021
Labels Added: ? NPM Resource Changed
avatar ceford
ceford - comment - 29 Nov 2021

I inserted the field in Advanced tab of mod_custon.xml, went to Modules / New / Custom Html and the field is there with the default content. If I follow the instructions in #35096 i get the editor field with line number but not the default content. The gutter is wide and the typed text appears in the correct place. So, just the default text is missing.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36140.

avatar Fedik
Fedik - comment - 29 Nov 2021

That is correct, instruction from #35096 does not have default value, there should be just an empty editor.

avatar RickR2H RickR2H - test_item - 15 Dec 2021 - Tested successfully
avatar RickR2H
RickR2H - comment - 15 Dec 2021

I have tested this item ✅ successfully on 4a9e06f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36140.

avatar RickR2H
RickR2H - comment - 15 Dec 2021

Make sure to refresh the browser cache when testing!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36140.

avatar dgrammatiko dgrammatiko - test_item - 15 Dec 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 15 Dec 2021

I have tested this item ✅ successfully on 4a9e06f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36140.

avatar ricardo1709 ricardo1709 - test_item - 16 Dec 2021 - Tested successfully
avatar ricardo1709
ricardo1709 - comment - 16 Dec 2021

I have tested this item ✅ successfully on 4a9e06f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36140.

avatar RickR2H RickR2H - change - 16 Dec 2021
Status Pending ⇒ Ready to Commit
avatar RickR2H
RickR2H - comment - 16 Dec 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36140.

avatar wilsonge wilsonge - change - 4 Jan 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-01-04 00:52:06
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 4 Jan 2022
avatar wilsonge wilsonge - merge - 4 Jan 2022
avatar wilsonge
wilsonge - comment - 4 Jan 2022

Thanks!

Add a Comment

Login with GitHub to post a comment