? ? Pending

User tests: Successful: Unsuccessful:

avatar khu5h1
khu5h1
26 Nov 2021

Pull Request for Issue #36113 .

Summary of Changes

Added $required = $required ? ' required aria-required="true"' : ''; above $autocomplete.

Actual result BEFORE applying this Pull Request

<input type="text" name="jform[color]" id="jform_color" value="#000000" placeholder="#rrggbb" class="minicolors required hex" data-position="default" data-control="hue"1 data-format="hex"/>

Expected result AFTER applying this Pull Request

<input type="text" name="jform[color]" id="jform_color" value="#000000" placeholder="#rrggbb" class="minicolors required hex" data-position="default" data-control="hue" data-format="hex"/>

Documentation Changes Required

No

avatar khu5h1 khu5h1 - open - 26 Nov 2021
avatar khu5h1 khu5h1 - change - 26 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2021
Category Layout
avatar brianteeman
brianteeman - comment - 26 Nov 2021

You don't need to add the aria-required=true. Its enough to just say required

avatar khu5h1 khu5h1 - change - 26 Nov 2021
Labels Added: ?
avatar khu5h1
khu5h1 - comment - 26 Nov 2021

@brianteeman I have committed the desired changes.

avatar ceford
ceford - comment - 29 Nov 2021

I think we need some specific instructions on how to test this. Where do we find a color filed? Or why can we create one?
Poor instructions = no test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.

avatar brianteeman
brianteeman - comment - 29 Nov 2021
  1. Create a custom field for an article of type color and set it to be required.
  2. Go to the article and view the source of the field

The source of the field will be displayed as in the first post

avatar Quy
Quy - comment - 29 Nov 2021

I have tested this item successfully on bcad5d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.

avatar Quy Quy - test_item - 29 Nov 2021 - Tested successfully
avatar manav014
manav014 - comment - 29 Nov 2021

I have tested this item successfully on bcad5d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.

avatar manav014 manav014 - test_item - 29 Nov 2021 - Tested successfully
avatar Quy Quy - change - 29 Nov 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.

avatar chmst chmst - change - 1 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-01 18:58:39
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 1 Dec 2021
avatar chmst chmst - merge - 1 Dec 2021
avatar chmst
chmst - comment - 1 Dec 2021

thanks

Add a Comment

Login with GitHub to post a comment