[#36122] - Solve required field attribute causing rendering error
- Fixed in Code Base
- 1 Dec 2021
- Medium
- Build: 4.0-dev
- # 36122
- Diff
- khu5h1:issue_36113
User tests: Successful: Unsuccessful:
Pull Request for Issue #36113 .
Summary of Changes
Added $required = $required ? ' required aria-required="true"' : ''; above $autocomplete.
Actual result BEFORE applying this Pull Request
<input type="text" name="jform[color]" id="jform_color" value="#000000" placeholder="#rrggbb" class="minicolors required hex" data-position="default" data-control="hue"1 data-format="hex"/>
Expected result AFTER applying this Pull Request
<input type="text" name="jform[color]" id="jform_color" value="#000000" placeholder="#rrggbb" class="minicolors required hex" data-position="default" data-control="hue" data-format="hex"/>
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
@brianteeman I have committed the desired changes.
I think we need some specific instructions on how to test this. Where do we find a color filed? Or why can we create one?
Poor instructions = no test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.
- Create a custom field for an article of type color and set it to be required.
- Go to the article and view the source of the field
The source of the field will be displayed as in the first post
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36122.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-01 18:58:39 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
thanks
You don't need to add the aria-required=true. Its enough to just say required