No Code Attached Yet
avatar arlexwong
arlexwong
26 Nov 2021

Steps to reproduce the issue

This issue happens when the 3rd party component uses Joomla simplepie library and PHP 8.

JoomlaFolder/libraries/vendor/simplepie/simplepie/library/SimplePie/Parse/Date.php
LINE 544 and 545

0 implode(): Argument # 2 ($array) must be of type ?array, string given

		$this->day_pcre = '(' . implode(array_keys($this->day), '|') . ')';
		$this->month_pcre = '(' . implode(array_keys($this->month), '|') . ')';

Expected result

PHP syntax error

  • implode(separator,array)

Actual result

It works fine in PHP 5.x and PHP 7.x except PHP 8.

System information (as much as possible)

Joomla 3.10.3, PHP 8

Additional comments

avatar arlexwong arlexwong - open - 26 Nov 2021
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 26 Nov 2021
avatar arlexwong arlexwong - change - 26 Nov 2021
The description was changed
avatar arlexwong arlexwong - edited - 26 Nov 2021
avatar brianteeman
brianteeman - comment - 26 Nov 2021

Looks like a problem upstream in simplepie https://github.com/simplepie/simplepie/issues

avatar zero-24
zero-24 - comment - 26 Nov 2021

We are shipping an outdated and by the core unused lib here. Within the core we IIRC use our own Feed lib for now. We can not upgrade to the latest version because of the php version supported by J3. J4 does no longer ship with this lib.

So i guess we have to build another backport repo and try to make it compatible with php8.. or mark it as known behavior when that is not possible.

avatar zero-24
zero-24 - comment - 26 Nov 2021

Ok looks like there is still a 1.3 branch that supports php 5.3, but I'm not sure whether they still support that branch in the meaning of doing releases. I have just done a PR + that question lets see what they say: simplepie/simplepie#702

avatar zero-24 zero-24 - change - 20 Dec 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-12-20 14:57:20
Closed_By zero-24
avatar zero-24 zero-24 - close - 20 Dec 2021
avatar zero-24
zero-24 - comment - 20 Dec 2021

Hi @arlexwong please test: #36358

Add a Comment

Login with GitHub to post a comment