[#36112] - 4.1 TinyMCE source code plugin clean up
- Fixed in Code Base
- 15 Jan 2022
- Medium
- Build: 4.1-dev
- # 36112
- Diff
- dgrammatiko:4.1-dev-tm-cm
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Tweaked the modal window size
- Moved files to ES6 so they can be linted
- Removed the
document.write
Testing Instructions
Check that the source code is still working as expected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
NO
@Fedik mainly this PR is an alternative to your commit for the removal of the document.write which I reverted as it wasn't working. Can you review this one?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36112.
Depending on the size of the screen this is miscaclulating the height of the codemirror window and as a result you cannot get to the top or the bottom
Before this pr the window could be closed with the escape key. Now it has to be done from the button
Before this pr the window could be closed with the escape key. Now it has to be done from the button
Which browser? Works fine in Chrome here
I found out why/when the escape key didnt work. If you click outside of the window then the escape doesnt work. Not sure if it should or shouldnt
I found out why/when the escape key didnt work. If you click outside of the window then the escape doesnt work. Not sure if it should or shouldnt
Ah, that's expected (code wise) as the listener is added in the iframe document and when you click outside of the modal you change scope to the parent document (which doesn't have any code to handle the modal). Let me check something...
@brianteeman I restored the original sizing for the time. We could tackle this in another PR
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36112.
| Category | JavaScript Repository NPM Change Front End Plugins | ⇒ | JavaScript Repository NPM Change |
| Category | JavaScript Repository NPM Change | ⇒ | JavaScript Repository NPM Change Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36112.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36112.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36112.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36112.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-15 00:26:34 |
| Closed_By | ⇒ | bembelimen |
Thx
Looks good to me :)