? ? Pending

User tests: Successful: Unsuccessful:

avatar Shubhamverma2796
Shubhamverma2796
24 Nov 2021

Pull request for

Pull request for issue #36096

Summary of Changes

Validated type=number for the administration modules.

Testing Instructions

  1. Select Content-->Administrator module.
  2. Try to create new modules by setting -ve values in where type="number"

Actual result BEFORE applying this Pull Request

Modules will be saved successfully with -ve values

Expected result AFTER applying this Pull Request

Invalid field message is displayed.

avatar Shubhamverma2796 Shubhamverma2796 - open - 24 Nov 2021
avatar Shubhamverma2796 Shubhamverma2796 - change - 24 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Nov 2021
Category Modules Administration
avatar Shubhamverma2796 Shubhamverma2796 - change - 24 Nov 2021
The description was changed
avatar Shubhamverma2796 Shubhamverma2796 - edited - 24 Nov 2021
avatar Ravi-chandra69 Ravi-chandra69 - test_item - 24 Nov 2021 - Not tested
avatar Ravi-chandra69 Ravi-chandra69 - test_item - 24 Nov 2021 - Tested successfully
avatar Ravi-chandra69
Ravi-chandra69 - comment - 24 Nov 2021

I have tested this item successfully on e9f4a76

Followed the testing instructions and the patch worked successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36100.

avatar richard67
richard67 - comment - 24 Nov 2021

@Shubhamverma2796 When making a pull request to solve an issue, please refer to the issue at the top of the PR description. In this case here it should be:

Pull request for issue #36096 .

Thanks in advance.

avatar Shubhamverma2796 Shubhamverma2796 - change - 24 Nov 2021
The description was changed
avatar Shubhamverma2796 Shubhamverma2796 - edited - 24 Nov 2021
avatar pritam825 pritam825 - test_item - 24 Nov 2021 - Tested successfully
avatar pritam825
pritam825 - comment - 24 Nov 2021

I have tested this item successfully on e9f4a76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36100.

avatar alikon alikon - change - 24 Nov 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 24 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36100.

avatar wilsonge wilsonge - change - 24 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-24 15:16:58
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 24 Nov 2021
avatar wilsonge wilsonge - merge - 24 Nov 2021
avatar wilsonge
wilsonge - comment - 24 Nov 2021

Thanks!

Add a Comment

Login with GitHub to post a comment