[#36032] - [4.0] header.css unused
- Fixed in Code Base
- 28 Nov 2021
- Medium
- Build: 4.0-dev
- # 36032
- Diff
- brianteeman:atem-unused-header
User tests: Successful: Unsuccessful:
To the best of my knowledge and testing ability these classes are no longer used and can be safely removed. It looks like they were missed during the numerous refactoring of the atum template.
When testing either confirm they are not used by code review and/or check that the ... menu is still working as desired on smaller screens
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I was testing the menu on different screens, and this is what I've found for "Galaxy fold",
:
The above image shows that "20" is not visible clearly; it is getting overlapped.
Ps: Menu is working as desired for other screen sizes
Is it the same before this PR - I suspect it is - therefore it is completely unrelated to this PR and you should create a new issue for that
Okay, I will open a new issue for this.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36032.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36032.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36032.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-28 17:16:21 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
NPM Resource Changed
|
||
Thanks!
Thanks
I have tested this item✅ successfully on 693e008
On Code Review and checked menu is still working as desired.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36032.